Bug 215068 - [LFC][IFC] LineBuilder:Run should not have vertical geometry
Summary: [LFC][IFC] LineBuilder:Run should not have vertical geometry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: LFC 215752
  Show dependency tree / graph
 
Reported: 2020-08-01 17:24 PDT by zalan
Modified: 2020-08-27 20:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (28.93 KB, patch)
2020-08-01 17:35 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (29.38 KB, patch)
2020-08-27 06:06 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
Patch (52.29 KB, patch)
2020-08-27 08:45 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (29.51 KB, patch)
2020-08-27 08:54 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (35.79 KB, patch)
2020-08-27 16:21 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (36.14 KB, patch)
2020-08-27 16:55 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (36.78 KB, patch)
2020-08-27 19:05 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-08-01 17:24:50 PDT 
LineBuilder does not align runs vertically (actually no alignment at all)
Comment 1 zalan 2020-08-01 17:35:53 PDT 
Created attachment 405801 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-08-08 17:25:15 PDT 
<rdar://problem/66736366>
Comment 3 zalan 2020-08-27 06:06:44 PDT 
Created attachment 407394 [details]
Patch
Comment 4 Antti Koivisto 2020-08-27 06:14:27 PDT 
Comment on attachment 407394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407394&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:178
> -            // and the trimmed width should be capped at std::min(run.trailingWhitespaceWidth(), overflowWidth) for texgt runs. Both FF and Chrome agree.
> +            // and the trimmed width should be capped at std::min(run.trailingWhitespaceWidth(), overflowWidth) for text runs. Both FF and Chrome agree.

Great spelling fixes!

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:394
> -    // Note that just becasue the trimmable width is 0 (font-size: 0px), it does not mean we don't have a trimmable trailing content.
> +    // Note that just because the trimmable width is 0 (font-size: 0px), it does not mean we don't have a trimmable trailing content.

Here too.

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:401
> -    // Do not add trimmable letter spacing after a fully trimmable whitesapce.
> +    // Do not add trimmable letter spacing after a fully trimmable whitespace.

And here.
Comment 5 zalan 2020-08-27 08:45:21 PDT 
Created attachment 407402 [details]
Patch
Comment 6 zalan 2020-08-27 08:54:36 PDT 
Created attachment 407403 [details]
Patch
Comment 7 zalan 2020-08-27 16:21:21 PDT 
Created attachment 407432 [details]
Patch
Comment 8 zalan 2020-08-27 16:55:26 PDT 
Created attachment 407438 [details]
Patch
Comment 9 zalan 2020-08-27 19:05:03 PDT 
Created attachment 407444 [details]
Patch
Comment 10 EWS 2020-08-27 20:07:11 PDT 
Committed r266271: <https://trac.webkit.org/changeset/266271>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407444 [details].