RESOLVED FIXED 21506
Fix setUpPageStatus variable in two layout tests 
https://bugs.webkit.org/show_bug.cgi?id=21506
Summary Fix setUpPageStatus variable in two layout tests
Pam Greene (IRC:pamg)
Reported 2008-10-09 14:07:31 PDT
In these two tests, the variable |setUpPageStatus| is set to 'running', but |setUpPage| is set to 'complete'.
Attachments
Fixes variable names to match (1.78 KB, patch)
2008-10-09 14:17 PDT, Pam Greene (IRC:pamg) 		darin: review+
DetailsFormatted DiffDiff
Add comments (2.30 KB, patch)
2008-10-10 10:32 PDT, Pam Greene (IRC:pamg) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pam Greene (IRC:pamg)
Comment 1 2008-10-09 14:17:23 PDT
Created attachment 24235 [details] Fixes variable names to match This bug affects two test files. The results are unchanged.
Darin Adler
Comment 2 2008-10-10 09:32:55 PDT
Comment on attachment 24235 [details] Fixes variable names to match The LayoutTests/dom tests were imported from an external source. Originally our goal was to leave them as-is, and so we've made only minimal changes to them. Back in 2005 we used to put comments around any WebKit modifications. For example, search for WebKit in html/level1/core/selfhtml.js. Later, we would still normally add comments. Seearch fro WebKit in svg/level3/xpath/Text_Nodes.js. So I think it would be slightly better to add a comment about the change, due to the special status of LayoutTests/dom. But this is good as-is I suppose. I'll just say r=me
Pam Greene (IRC:pamg)
Comment 3 2008-10-10 10:32:47 PDT
Created attachment 24265 [details] Add comments No problem; here's one with comments. Is there documentation somewhere listing which tests are imported from elsewhere?
Darin Adler
Comment 4 2008-10-10 14:04:03 PDT
Comment on attachment 24265 [details] Add comments The URLs should be https. r=me
Adam Barth
Comment 5 2008-10-12 13:46:07 PDT
I'll land this.
Adam Barth
Comment 6 2008-10-12 18:59:16 PDT
Fixed in r37549.
Note You need to log in before you can comment on or make changes to this bug.