RESOLVED FIXED215038
REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite flags in safaripy 
https://bugs.webkit.org/show_bug.cgi?id=215038
Summary REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other -...
Blaze Burg
Reported 2020-07-31 15:28:07 PDT
.
Attachments
Patch (2.01 KB, patch)
2020-07-31 15:41 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (2.01 KB, patch)
2020-08-03 09:18 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-07-31 15:29:04 PDT
<rdar://problem/66401661>
Blaze Burg
Comment 2 2020-07-31 15:41:08 PDT
Created attachment 405750 [details] Patch
Jonathan Bedard
Comment 3 2020-07-31 16:32:25 PDT
Comment on attachment 405750 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405750&action=review > Tools/Scripts/webkitpy/results/options.py:34 > + optparse.make_option('--' + suite_name_flag, help='Optional flag for overriding reported suite name.', default=None), Note that since the caller of this will be the bit using the flag, we don't need to try anything fancy to change how we consume the flag, that's up to the code instantiation the options.
EWS
Comment 4 2020-07-31 16:37:05 PDT
Invalid ChangeLog at /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog
Blaze Burg
Comment 5 2020-08-03 09:18:21 PDT
Created attachment 405836 [details] Patch
EWS
Comment 6 2020-08-03 09:59:31 PDT
Committed r265201: <https://trac.webkit.org/changeset/265201> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405836 [details].
Note You need to log in before you can comment on or make changes to this bug.