Bug 215038 - REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite flags in safaripy
Summary: REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other -...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-31 15:28 PDT by BJ Burg
Modified: 2020-08-03 09:59 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2020-07-31 15:41 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2020-08-03 09:18 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2020-07-31 15:28:07 PDT 
.
Comment 1 Radar WebKit Bug Importer 2020-07-31 15:29:04 PDT 
<rdar://problem/66401661>
Comment 2 BJ Burg 2020-07-31 15:41:08 PDT 
Created attachment 405750 [details]
Patch
Comment 3 Jonathan Bedard 2020-07-31 16:32:25 PDT 
Comment on attachment 405750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405750&action=review

> Tools/Scripts/webkitpy/results/options.py:34
> +        optparse.make_option('--' + suite_name_flag, help='Optional flag for overriding reported suite name.', default=None),

Note that since the caller of this will be the bit using the flag, we don't need to try anything fancy to change how we consume the flag, that's up to the code instantiation the options.
Comment 4 EWS 2020-07-31 16:37:05 PDT 
Invalid ChangeLog at /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog
Comment 5 BJ Burg 2020-08-03 09:18:21 PDT 
Created attachment 405836 [details]
Patch
Comment 6 EWS 2020-08-03 09:59:31 PDT 
Committed r265201: <https://trac.webkit.org/changeset/265201>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405836 [details].