Bug 215022 – [Mac] YouTube does not offer HDR variants to devices which support HDR

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Mac] YouTube does not offer HDR variants to devices which support HDR

[Jer Noble]

<rdar://problem/65188503>

[Jer Noble]

Created attachment 405720 [details]
Patch

[Jer Noble]

Created attachment 405725 [details]
Patch

[Eric Carlson]

Comment on attachment 405725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405725&action=review

> Source/WebCore/Modules/mediasource/MediaSource.cpp:724
> +    if (scriptExecutionContext() && scriptExecutionContext()->isDocument() && downcast<Document>(scriptExecutionContext())->quirks().needsVP9FullRangeFlagQuirk())

Any you use `context`?

> Source/WebCore/Modules/mediasource/MediaSource.cpp:1079
> +    if (scriptExecutionContext() && scriptExecutionContext()->isDocument() && downcast<Document>(scriptExecutionContext())->quirks().needsVP9FullRangeFlagQuirk())

A local context variable would be better than calling `scriptExecutionContext()` multiple times.

[Eric Carlson]

Comment on attachment 405725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405725&action=review

>> Source/WebCore/Modules/mediasource/MediaSource.cpp:724
>> +    if (scriptExecutionContext() && scriptExecutionContext()->isDocument() && downcast<Document>(scriptExecutionContext())->quirks().needsVP9FullRangeFlagQuirk())
> 
> Any you use `context`?

*Can* you use...

[Jer Noble]

Created attachment 405737 [details]
Patch for landing

[Jer Noble]

Created attachment 405744 [details]
Patch for landing

[EWS]

Committed r265167: <https://trac.webkit.org/changeset/265167>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405744 [details].

[Ryan Haddad]

This change broke the Windows build:
C:\cygwin\worker\win10-release\build\Source\WebCore\page/Screen.cpp(90,30): error C2027: use of undefined type 'WebCore::DOMWindow' [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\worker\win10-release\build\Source\WebCore\page\DOMWindowProperty.h(32): message : see declaration of 'WebCore::DOMWindow' [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\worker\win10-release\build\Source\WebCore\page/Screen.cpp(91,8): error C3536: 'document': cannot be used before it is initialized [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/15541/steps/compile-webkit/logs/stdio

[Jer Noble]

(In reply to Ryan Haddad from comment #9)
> This change broke the Windows build:
> C:\cygwin\worker\win10-release\build\Source\WebCore\page/Screen.cpp(90,30):
> error C2027: use of undefined type 'WebCore::DOMWindow'
> [C:\cygwin\worker\win10-
> release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
> C:\cygwin\worker\win10-release\build\Source\WebCore\page\DOMWindowProperty.
> h(32): message : see declaration of 'WebCore::DOMWindow'
> [C:\cygwin\worker\win10-
> release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
> C:\cygwin\worker\win10-release\build\Source\WebCore\page/Screen.cpp(91,8):
> error C3536: 'document': cannot be used before it is initialized
> [C:\cygwin\worker\win10-
> release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
> https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/
> builds/15541/steps/compile-webkit/logs/stdio

Wow, found the one file in WebCore that doesn't include Document.h.

[Jer Noble]

Committed follow-up build fix in r265172 <https://trac.webkit.org/r265172>.