Bug 215017 - Convert LinkHeader to use StringParsingBuffer
Summary: Convert LinkHeader to use StringParsingBuffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-31 07:36 PDT by Sam Weinig
Modified: 2020-08-01 10:52 PDT (History)
5 users (show)

See Also:


Attachments
Patch (15.88 KB, patch)
2020-07-31 07:38 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-07-31 07:36:39 PDT
LinkHeader parsing should use StringParsingBuffer
Comment 1 Sam Weinig 2020-07-31 07:38:17 PDT
Created attachment 405692 [details]
Patch
Comment 2 Darin Adler 2020-08-01 10:39:50 PDT
Comment on attachment 405692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405692&action=review

> Source/WebCore/loader/LinkHeader.cpp:54
> -    if ((chr >= '^' && chr <= 'z') || (chr >= 'A' && chr <= 'Z') || (chr >= '0' && chr <= '9') || (chr >= '!' && chr <= '$') || chr == '&' || chr == '+' || chr == '-' || chr == '.')
> +    if ((character >= '^' && character <= 'z') || (character >= 'A' && character <= 'Z') || (character >= '0' && character <= '9') || (character >= '!' && character <= '$') || character == '&' || character == '+' || character == '-' || character == '.')
>          return true;
>      return false;

I’d like to see this be made shorter by using isASCIIAlphanumeric.

Also, I’d like to use return rather than if return true else return false.
Comment 3 EWS 2020-08-01 10:51:22 PDT
Committed r265177: <https://trac.webkit.org/changeset/265177>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405692 [details].
Comment 4 Radar WebKit Bug Importer 2020-08-01 10:52:16 PDT
<rdar://problem/66427205>