Bug 215016 - [LFC][IFC] LineBuilder should not align the runs
Summary: [LFC][IFC] LineBuilder should not align the runs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: LFC 215752
  Show dependency tree / graph
 
Reported: 2020-07-31 05:15 PDT by zalan
Modified: 2020-08-26 21:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch (48.36 KB, patch)
2020-07-31 05:19 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (48.74 KB, patch)
2020-08-26 10:16 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (48.74 KB, patch)
2020-08-26 12:16 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (48.70 KB, patch)
2020-08-26 19:26 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-07-31 05:15:11 PDT 
LineBuilder is responsible for adding content to the line but the alignment (horizontal/vertical) should be done by the LineBox.
Comment 1 zalan 2020-07-31 05:19:09 PDT 
Created attachment 405681 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-08-07 05:16:18 PDT 
<rdar://problem/66675537>
Comment 3 zalan 2020-08-26 10:16:04 PDT 
Created attachment 407309 [details]
Patch
Comment 4 zalan 2020-08-26 12:16:18 PDT 
Created attachment 407319 [details]
Patch
Comment 5 EWS 2020-08-26 19:23:46 PDT 
ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file.
Comment 6 zalan 2020-08-26 19:26:24 PDT 
Created attachment 407369 [details]
Patch
Comment 7 EWS 2020-08-26 21:36:42 PDT 
Committed r266222: <https://trac.webkit.org/changeset/266222>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407369 [details].