Bug 215014 - Move user gesture propagation over promise behind a feature flag
Summary: Move user gesture propagation over promise behind a feature flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-31 00:33 PDT by youenn fablet
Modified: 2020-08-03 18:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.53 KB, patch)
2020-07-31 00:36 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (8.88 KB, patch)
2020-07-31 03:49 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (10.48 KB, patch)
2020-07-31 06:37 PDT, youenn fablet 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (9.22 KB, patch)
2020-08-03 17:26 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-07-31 00:33:23 PDT 
Move user gesture propagation over promise behind a feature flag
Comment 1 youenn fablet 2020-07-31 00:36:19 PDT 
Created attachment 405675 [details]
Patch
Comment 2 youenn fablet 2020-07-31 03:49:19 PDT 
Created attachment 405679 [details]
Patch
Comment 3 youenn fablet 2020-07-31 06:37:05 PDT 
Created attachment 405686 [details]
Patch
Comment 4 Jiewen Tan 2020-07-31 12:38:36 PDT 
Hi Youenn,

Making user gesture being able to propagate through Fetch API is an important fix for this year's WebAuthn release. Can we have this feature turned on by default? Or we could make another scope just for WebAuthn.

Is there any reasons you feel unsafe to turn on this feature?
Comment 5 youenn fablet 2020-07-31 14:31:14 PDT 
> Is there any reasons you feel unsafe to turn on this feature?

Do you know if we are matching Mozilla behavior for fetch?

I guess we can turn on the feature for fetch and response getters.
Some things in the implementation could be ironed out there but this should be fine.
For ReadableStream, I think we should consolidate this and probably write a spec or at least get some discussion broader than WebKit.
Comment 6 Jiewen Tan 2020-07-31 19:19:45 PDT 
Comment on attachment 405686 [details]
Patch

Didn't see this is enabled for WebKitTestRunner, but surprisedly WK2 bots are green.
Comment 7 Jiewen Tan 2020-08-03 17:26:19 PDT 
Created attachment 405893 [details]
Patch for landing
Comment 8 Jiewen Tan 2020-08-03 17:26:57 PDT 
(In reply to Jiewen Tan from comment #7)
> Created attachment 405893 [details]
> Patch for landing

After talking to Youenn, he agrees to make the feature default on. Therefore, uploaded a patch with that.
Comment 9 EWS 2020-08-03 18:05:14 PDT 
Committed r265235: <https://trac.webkit.org/changeset/265235>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405893 [details].
Comment 10 Radar WebKit Bug Importer 2020-08-03 18:06:16 PDT 
<rdar://problem/66501182>