Bug 215013 - Clean up text layout code a bit
Summary: Clean up text layout code a bit
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
Keywords: InRadar
Depends on:
Blocks: 206208
  Show dependency treegraph
Reported: 2020-07-30 22:43 PDT by Myles C. Maxfield
Modified: 2020-08-07 23:23 PDT (History)
17 users (show)

See Also:

Patch (24.08 KB, patch)
2020-07-30 22:56 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (24.11 KB, patch)
2020-07-30 23:03 PDT, Myles C. Maxfield
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2020-07-30 22:43:30 PDT
Clean up text layout code a bit
Comment 1 Myles C. Maxfield 2020-07-30 22:56:48 PDT
Created attachment 405671 [details]
Comment 2 Radar WebKit Bug Importer 2020-07-30 22:57:35 PDT
Comment 3 Myles C. Maxfield 2020-07-30 23:03:56 PDT
Created attachment 405672 [details]
Comment 4 zalan 2020-07-31 16:59:01 PDT
Comment on attachment 405672 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=405672&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:1391
> +    float initialAdvance;

I always get scared when I see a non-initialized variable (I know it gets a value eventually).
Comment 5 Myles C. Maxfield 2020-07-31 17:36:19 PDT
Committed r265170: <https://trac.webkit.org/changeset/265170>