Bug 215010 – Reduce over include usage in JSC

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

Reduce over include usage in JSC

[Keith Miller]

Created attachment 405667 [details]
Patch

[Keith Miller]

Created attachment 405668 [details]
Patch

[Keith Miller]

Created attachment 405673 [details]
Patch

[Mark Lam]

Comment on attachment 405673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405673&action=review

r=me if bots are happy.

> Source/JavaScriptCore/runtime/VM.cpp:798
> +MacroAssemblerCodeRef<JITThunkPtrTag> VM::getCTIStub(ThunkGenerator generator)
> +{
> +    return jitStubs->ctiStub(*this, generator);
> +}

Optionally, this can go into VMInlines.h?

[Keith Miller]

Comment on attachment 405673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405673&action=review

>> Source/JavaScriptCore/runtime/VM.cpp:798
>> +}
> 
> Optionally, this can go into VMInlines.h?

Yeah, I don't think it's used anywhere really perf sensitive so I just put it here.

[EWS]

Committed r265142: <https://trac.webkit.org/changeset/265142>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405673 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66383243>

[Ryan Haddad]

This change broke the CLoop build:
https://build.webkit.org/builders/Apple-Catalina-LLINT-CLoop-BuildAndTest/builds/6218/steps/compile-webkit/logs/stdio

[Yusuke Suzuki]

Committed r265189: <https://trac.webkit.org/changeset/265189>

[Keith Miller]

(In reply to Yusuke Suzuki from comment #9)
> Committed r265189: <https://trac.webkit.org/changeset/265189>

Thanks for the fix!