Bug 215009 - Fix build around broken internal SDK for iOS 13
Summary: Fix build around broken internal SDK for iOS 13
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
Keywords: InRadar
Depends on:
Reported: 2020-07-30 21:59 PDT by Keith Miller
Modified: 2020-07-31 08:54 PDT (History)
8 users (show)

See Also:

Patch (2.75 KB, patch)
2020-07-30 22:02 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (2.38 KB, patch)
2020-07-30 23:49 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-07-30 21:59:36 PDT
Fix build around broken internal SDK for iOS 13
Comment 1 Keith Miller 2020-07-30 22:02:16 PDT
Created attachment 405666 [details]
Comment 2 Keith Miller 2020-07-30 22:03:46 PDT
CCing people that know more about the build to make sure there's not a more reasonable fix. I don't really understand why we are able to locate the <machine/cpu_capabilities.h> header when building JSC but not when building TestWebKitAPI...
Comment 3 Saam Barati 2020-07-30 23:08:28 PDT
Comment on attachment 405666 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=405666&action=review

> Source/JavaScriptCore/assembler/FastJITPermissions.h:33
> +// FIXME: We only need this because the internal SDK is broken for an update of iOS 13... D: But since it shipped that way it's probably too late to fix. See: rdar://66350584
> +#define HAVE_THREAD_SELF_RESTRICT USE(APPLE_INTERNAL_SDK) && __has_include(<machine/cpu_capabilities.h>)

this feels wrong. And could be indicative of other bugs. I'd prefer a better solution, but if this is all we have, better to unblock the build.

Might be worth asking a few other folks who know the build system better.

Also, please document what's going on in the radar
Comment 4 Keith Miller 2020-07-30 23:49:49 PDT
Created attachment 405674 [details]
Comment 5 Mark Lam 2020-07-30 23:53:10 PDT
Comment on attachment 405674 [details]

Comment 6 Keith Miller 2020-07-30 23:54:19 PDT
Comment 7 EWS 2020-07-31 08:54:34 PDT
Committed r265141: <https://trac.webkit.org/changeset/265141>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405674 [details].