Bug 215000 – Add the ability of comparing the accessibility tree with isolated tree mode on and off.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

Add the ability of comparing the accessibility tree with isolated tree mode on and off.

[Andres Gonzalez]

Created attachment 405650 [details]
Patch

[chris fleizach]

Comment on attachment 405650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405650&action=review

> LayoutTests/accessibility/mac/isolated-tree-mode-on-off.html:20
> +    if (window.accessibilityController) {

side-but related topic- can we also add something to ensure that the isolated tree objects are returned? maybe we can return an attribute from the WebObjectWrapper that exists only when our backing object is an isolated tree object

[Andres Gonzalez]

Created attachment 405696 [details]
Patch

[chris fleizach]

lots of build fails

[Andres Gonzalez]

Created attachment 405708 [details]
Patch

[Andres Gonzalez]

Created attachment 405712 [details]
Patch

[Andres Gonzalez]

Created attachment 405719 [details]
Patch

[Andres Gonzalez]

Created attachment 405724 [details]
Patch

[Andres Gonzalez]

Created attachment 405734 [details]
Patch

[Andres Gonzalez]

Created attachment 405787 [details]
Patch

[chris fleizach]

Comment on attachment 405787 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405787&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:379
> +    return backingObject ? backingObject->isAXIsolatedObjectInstance() : NO;

This could be

return backingObject && backingObject->.....

[Andres Gonzalez]

Created attachment 405811 [details]
Patch

[Andres Gonzalez]

Created attachment 405837 [details]
Patch

[chris fleizach]

Comment on attachment 405837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405837&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:379
> +    return backingObject ? backingObject->isAXIsolatedObjectInstance() : NO;

this could just be

return backingObject && backingObject->isAXIsolatedObjectInstance();

[Andres Gonzalez]

Created attachment 405840 [details]
Patch

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 405840 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[Andres Gonzalez]

Created attachment 405895 [details]
Patch

[EWS]

Committed r265248: <https://trac.webkit.org/changeset/265248>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405895 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66528080>