Bug 214995 – Log a warning to the dev console when gamepads are accessed from an insecure context

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Log a warning to the dev console when gamepads are accessed from an insecure context

This is to prep for the eventual restriction to secure contexts

https://github.com/w3c/gamepad/pull/120

[Brady Eidson]

Created attachment 405735 [details]
Patch

[Tim Horton]

Comment on attachment 405735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405735&action=review

> Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:80
> +    RELEASE_ASSERT(domWindow);
> +    auto* document = domWindow->document();
> +    RELEASE_ASSERT(document);

These seem ... aggressive? Why not just bail?

[Brady Eidson]

(In reply to Tim Horton from comment #2)
> Comment on attachment 405735 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405735&action=review
> 
> > Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:80
> > +    RELEASE_ASSERT(domWindow);
> > +    auto* document = domWindow->document();
> > +    RELEASE_ASSERT(document);
> 
> These seem ... aggressive? Why not just bail?

Yah, because the signature to return an actual array is a bummer.
I'll deal with it now sub optimally.

[Brady Eidson]

Created attachment 405736 [details]
Patch

[EWS]

Committed r265160: <https://trac.webkit.org/changeset/265160>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405736 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66401022>

[Darin Adler]

Comment on attachment 405736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405736&action=review

> Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:86
> +        static std::once_flag onceFlag;
> +        std::call_once(onceFlag, [document] {

I noticed that lots of people use the thread-safe std::call_once in code that otherwise is not thread safe. I often ask them to use a boolean instead. Am I the baddie?

[Aakash Jain]

(In reply to EWS from comment #5)
> Committed r265160: <https://trac.webkit.org/changeset/265160>
This introduced a broken test for windows: http/tests/misc/gamepads-insecure.html 

EWS also warned about this failure, tracked in Bug 215099.