Bug 214978 - [macOS] Date/time input types should have a textfield appearance
Summary: [macOS] Date/time input types should have a textfield appearance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-30 11:05 PDT by Aditya Keerthi
Modified: 2020-08-19 06:05 PDT (History)
12 users (show)

See Also:

Attachments
Patch (9.63 KB, patch)
2020-07-30 12:10 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch (22.21 KB, patch)
2020-07-30 13:04 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch (12.12 KB, patch)
2020-07-31 08:19 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2020-07-30 11:05:47 PDT 
...
Comment 1 Aditya Keerthi 2020-07-30 12:10:47 PDT 
Created attachment 405596 [details]
Patch
Comment 2 Aditya Keerthi 2020-07-30 13:04:35 PDT 
Created attachment 405599 [details]
Patch
Comment 3 Aditya Keerthi 2020-07-31 08:19:05 PDT 
Created attachment 405694 [details]
Patch
Comment 4 Wenson Hsieh 2020-07-31 12:39:41 PDT 
Comment on attachment 405694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405694&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:402
> +    return "input[type=\"week\"] { -webkit-appearance: textfield; align-items: center; display: -webkit-inline-flex; overflow: hidden; width: 10em; outline: none; } "_s;

This seems fine for now, but given that they’re all the same style rules, we might want to consider just refactoring these styles to be under something like `RenderTheme::dateAndTimeInputStyleSheet()`, or to be inside html.css as "input[type=date], input[type=time], … { … }".
Comment 5 Aditya Keerthi 2020-07-31 12:56:30 PDT 
(In reply to Wenson Hsieh from comment #4)
> Comment on attachment 405694 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405694&action=review
> 
> > Source/WebCore/rendering/RenderThemeMac.mm:402
> > +    return "input[type=\"week\"] { -webkit-appearance: textfield; align-items: center; display: -webkit-inline-flex; overflow: hidden; width: 10em; outline: none; } "_s;
> 
> This seems fine for now, but given that they’re all the same style rules, we
> might want to consider just refactoring these styles to be under something
> like `RenderTheme::dateAndTimeInputStyleSheet()`, or to be inside html.css
> as "input[type=date], input[type=time], … { … }".

Sounds good! I will be making more changes to the stylesheet in upcoming patches.
Comment 6 EWS 2020-07-31 13:19:06 PDT 
Committed r265157: <https://trac.webkit.org/changeset/265157>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405694 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-31 13:20:17 PDT 
<rdar://problem/66395553>