Bug 214978 – [macOS] Date/time input types should have a textfield appearance

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

...

[Aditya Keerthi]

Created attachment 405596 [details]
Patch

[Aditya Keerthi]

Created attachment 405599 [details]
Patch

[Aditya Keerthi]

Created attachment 405694 [details]
Patch

[Wenson Hsieh]

Comment on attachment 405694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405694&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:402
> +    return "input[type=\"week\"] { -webkit-appearance: textfield; align-items: center; display: -webkit-inline-flex; overflow: hidden; width: 10em; outline: none; } "_s;

This seems fine for now, but given that they’re all the same style rules, we might want to consider just refactoring these styles to be under something like `RenderTheme::dateAndTimeInputStyleSheet()`, or to be inside html.css as "input[type=date], input[type=time], … { … }".

[Aditya Keerthi]

(In reply to Wenson Hsieh from comment #4)
> Comment on attachment 405694 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405694&action=review
> 
> > Source/WebCore/rendering/RenderThemeMac.mm:402
> > +    return "input[type=\"week\"] { -webkit-appearance: textfield; align-items: center; display: -webkit-inline-flex; overflow: hidden; width: 10em; outline: none; } "_s;
> 
> This seems fine for now, but given that they’re all the same style rules, we
> might want to consider just refactoring these styles to be under something
> like `RenderTheme::dateAndTimeInputStyleSheet()`, or to be inside html.css
> as "input[type=date], input[type=time], … { … }".

Sounds good! I will be making more changes to the stylesheet in upcoming patches.

[EWS]

Committed r265157: <https://trac.webkit.org/changeset/265157>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405694 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66395553>