Bug 214976 - Drop ProcessAssertion::Client and replace with a simple invalidation handler
Summary: Drop ProcessAssertion::Client and replace with a simple invalidation handler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-30 10:14 PDT by Chris Dumez
Modified: 2020-07-31 15:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.15 KB, patch)
2020-07-30 10:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (9.19 KB, patch)
2020-07-30 12:02 PDT, Chris Dumez 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-07-30 10:14:56 PDT 
Drop ProcessAssertion::Client and replace with a simple invalidation handler.
Comment 1 Chris Dumez 2020-07-30 10:22:10 PDT 
Created attachment 405588 [details]
Patch
Comment 2 Chris Dumez 2020-07-30 12:02:11 PDT 
Created attachment 405594 [details]
Patch
Comment 3 Chris Dumez 2020-07-31 10:39:46 PDT 
Comment on attachment 405594 [details]
Patch

Ready for review.
Comment 4 Brady Eidson 2020-07-31 15:20:57 PDT 
Comment on attachment 405594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405594&action=review

> Source/WebKit/UIProcess/ProcessAssertion.cpp:55
> +ProcessAndUIAssertion::~ProcessAndUIAssertion()
> +{
> +}

Why an explicitly defined empty d'tor? Default one not good enough?
Comment 5 Chris Dumez 2020-07-31 15:23:15 PDT 
Committed r265162: <https://trac.webkit.org/changeset/265162>
Comment 6 Radar WebKit Bug Importer 2020-07-31 15:24:48 PDT 
<rdar://problem/66401490>