Bug 214962 – Web content gets stuck in an inactive state (no cursor updates or text insertion caret) when activating a tab with a thumbnail visible

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Web content gets stuck in an inactive state (no cursor updates or text insertion caret) when activating a tab with a thumbnail visible

[Tim Horton]

Created attachment 405560 [details]
Patch

[Tim Horton]

<rdar://problem/65670984>

[Wenson Hsieh]

Comment on attachment 405560 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405560&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3859
> +        m_page->activityStateDidChange(WebCore::ActivityState::allFlags());

Nit - is there value in being more specific than `allFlags()` here?

[Tim Horton]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 405560 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405560&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3859
> > +        m_page->activityStateDidChange(WebCore::ActivityState::allFlags());
> 
> Nit - is there value in being more specific than `allFlags()` here?

I don't think so. It's a minor perf hit, but

1) use of WKThumbnailView's window trickles indirectly into *most* of the flags, and
2) I don't want people to have to keep track of #1 in the future when adding new flags.
3) You're already flinging views around, so the perf hit of asking the view and window a few questions is almost certainly negligible.

[Tim Horton]

(We do diffing before doing anything more expensive)

[EWS]

Committed r265091: <https://trac.webkit.org/changeset/265091>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405560 [details].