Bug 214960 – Performance.getEntriesByName/Type should match case sensitive

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Rob Buis]

Performance.getEntriesByName/Type should match case sensitive, see:
https://w3c.github.io/performance-timeline/#getentriesbytype-method

[Rob Buis]

Created attachment 405555 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Rob Buis]

Created attachment 405558 [details]
Patch

[youenn fablet]

Comment on attachment 405558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405558&action=review

> LayoutTests/imported/w3c/web-platform-tests/performance-timeline/case-sensitivity.any.js:6
> +    var mixedList = self.performance.getEntriesByType("ReSoUrCe");

Can we add more tests for other strings: mark, measure, paint?

[Rob Buis]

(In reply to youenn fablet from comment #4)
> Comment on attachment 405558 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405558&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/performance-timeline/case-sensitivity.any.js:6
> > +    var mixedList = self.performance.getEntriesByType("ReSoUrCe");
> 
> Can we add more tests for other strings: mark, measure, paint?

I added a test (https://github.com/web-platform-tests/wpt/pull/24826) but no review until now. I'll land the patch since I waited long enough now.

[youenn fablet]

(In reply to Rob Buis from comment #5)
> (In reply to youenn fablet from comment #4)
> > Comment on attachment 405558 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=405558&action=review
> > 
> > > LayoutTests/imported/w3c/web-platform-tests/performance-timeline/case-sensitivity.any.js:6
> > > +    var mixedList = self.performance.getEntriesByType("ReSoUrCe");
> > 
> > Can we add more tests for other strings: mark, measure, paint?
> 
> I added a test (https://github.com/web-platform-tests/wpt/pull/24826) but no
> review until now. I'll land the patch since I waited long enough now.

I added a review.

[EWS]

Committed r265243: <https://trac.webkit.org/changeset/265243>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405558 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66511734>

[Rob Buis]

(In reply to youenn fablet from comment #6)
> > I added a test (https://github.com/web-platform-tests/wpt/pull/24826) but no
> > review until now. I'll land the patch since I waited long enough now.
> 
> I added a review.

Thanks! It landed now.