Highlight color does not switch after being set it system preferences.
Created attachment 405507 [details]
Comment on attachment 405507 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=405507&action=review
> + After the changes to the sandbox and how defaults are being transferred to the web process,
This should probably reference a commit.
> + after setting the defaults so that the value is retried after it is actually set and we do
"value is retried" -> "cache is invalidated"
You might even mention which cache (colorCache in RenderTheme)...
> + [notificationCenter postNotificationName:@"NSSystemColorsWillChangeNotification" object:nil];
> + [notificationCenter postNotificationName:NSSystemColorsDidChangeNotification object:nil];
While it looks weird that "WillChange" and "DidChange" are adjacent without the change sitting between them, this does match what happens in AppKit.
Created attachment 405508 [details]
Comment on attachment 405508 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=405508&action=review
> +static const WTF::String& userHighlightColorPreferenceKey()
Space above here.
Created attachment 405514 [details]
Committed r265072: <https://trac.webkit.org/changeset/265072>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 405514 [details].