Bug 214938 – Highlight color does not switch after being set it system preferences.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Highlight color does not switch after being set it system preferences.

[Megan Gardner]

Created attachment 405507 [details]
Patch

[Tim Horton]

Comment on attachment 405507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405507&action=review

> Source/WebKit/ChangeLog:9
> +        After the changes to the sandbox and how defaults are being transferred to the web process,

This should probably reference a commit.

> Source/WebKit/ChangeLog:11
> +        after setting the defaults so that the value is retried after it is actually set and we do

"value is retried" -> "cache is invalidated"

You might even mention which cache (colorCache in RenderTheme)...

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:953
> +        [notificationCenter postNotificationName:@"NSSystemColorsWillChangeNotification" object:nil];
> +        [notificationCenter postNotificationName:NSSystemColorsDidChangeNotification object:nil];

While it looks weird that "WillChange" and "DidChange" are adjacent without the change sitting between them, this does match what happens in AppKit.

[Megan Gardner]

Created attachment 405508 [details]
Patch

[Tim Horton]

Comment on attachment 405508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405508&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:933
> +static const WTF::String& userHighlightColorPreferenceKey()

Space above here.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:938
> +

Not here.

[Megan Gardner]

Created attachment 405514 [details]
Patch

[EWS]

Committed r265072: <https://trac.webkit.org/changeset/265072>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405514 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66302507>

[Megan Gardner]

<rdar://problem/65270586>