Bug 214911 – Special HID mapping for the Dualshock 3 controller

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Special HID mapping for the Dualshock 3 controller

Of the controllers that work on macOS out of the box that are not supported by GameController framework, the DS3 is by far the most popular. It also happens to cleanly map to the Web Gamepad "standard" gamepad mapping.

This will be easy after https://bugs.webkit.org/show_bug.cgi?id=214910

[Radar WebKit Bug Importer]

<rdar://problem/66255198>

[Brady Eidson]

Created attachment 405651 [details]
Patch

[Sam Weinig]

Comment on attachment 405651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405651&action=review

> Source/WebCore/platform/gamepad/GamepadConstants.h:30
> +#import <IOKit/hid/IOHIDUsageTables.h>

This doesn't seem like this belongs in a platform file that is not OS(DARWIN) specific, or at least guarded by OS(DARWIN) in someway.

[Brady Eidson]

(In reply to Sam Weinig from comment #3)
> Comment on attachment 405651 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405651&action=review
> 
> > Source/WebCore/platform/gamepad/GamepadConstants.h:30
> > +#import <IOKit/hid/IOHIDUsageTables.h>
> 
> This doesn't seem like this belongs in a platform file that is not
> OS(DARWIN) specific, or at least guarded by OS(DARWIN) in someway.

Yup quite right.

[Brady Eidson]

(In reply to Brady Eidson from comment #4)
> (In reply to Sam Weinig from comment #3)
> > Comment on attachment 405651 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=405651&action=review
> > 
> > > Source/WebCore/platform/gamepad/GamepadConstants.h:30
> > > +#import <IOKit/hid/IOHIDUsageTables.h>
> > 
> > This doesn't seem like this belongs in a platform file that is not
> > OS(DARWIN) specific, or at least guarded by OS(DARWIN) in someway.
> 
> Yup quite right.

That said only the Darwin platforms are broken and all the linucies work lol

[Brady Eidson]

Created attachment 405669 [details]
Patch

[Tim Horton]

Comment on attachment 405669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405669&action=review

> Source/WebCore/platform/gamepad/GamepadConstants.h:58
> +extern const size_t numberStandardGamepadButtonsWithoutHomeButton;

number... Of?

[Brady Eidson]

Created attachment 405718 [details]
Patch

[EWS]

Committed r265156: <https://trac.webkit.org/changeset/265156>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405718 [details].