Bug 214907 – REGRESSION(r264476): Calling systemHasAC() regresses launch time performance

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

REGRESSION(r264476): Calling systemHasAC() regresses launch time performance

[Jer Noble]

<rdar://problem/66191430>

[Jer Noble]

Created attachment 405434 [details]
Patch

[Eric Carlson]

Comment on attachment 405434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405434&action=review

> Source/WebCore/platform/cocoa/PowerSourceNotifier.mm:44
>      if (status == NOTIFY_STATUS_OK)
>          m_tokenID = token;

If notify_register_dispatch failed, should this just return early instead of potentially calling notifyPowerSourceChanged()?

[Jer Noble]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 405434 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405434&action=review
> 
> > Source/WebCore/platform/cocoa/PowerSourceNotifier.mm:44
> >      if (status == NOTIFY_STATUS_OK)
> >          m_tokenID = token;
> 
> If notify_register_dispatch failed, should this just return early instead of
> potentially calling notifyPowerSourceChanged()?

I don't think so. Even if the register command fails, we'll still want to update the AC state next run loop.

[EWS]

Committed r265056: <https://trac.webkit.org/changeset/265056>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405434 [details].