WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
214874
Add EWS builder queue for Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=214874
Summary
Add EWS builder queue for Apple Silicon
Jonathan Bedard
Reported
2020-07-28 07:11:25 PDT
We should defend the Seed 3 build, along with some basic tools tests, on Apple Silicon.
Attachments
Patch
(3.39 KB, patch)
2020-07-28 07:18 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(4.40 KB, patch)
2020-07-28 09:01 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(4.79 KB, patch)
2020-07-28 12:14 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(4.77 KB, patch)
2020-07-28 12:16 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(6.27 KB, patch)
2020-07-29 10:03 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(6.96 KB, patch)
2020-07-29 14:25 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(6.99 KB, patch)
2020-07-29 15:25 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(6.99 KB, patch)
2020-07-29 15:42 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch for landing
(6.99 KB, patch)
2020-07-29 16:45 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(6.97 KB, patch)
2020-07-29 17:14 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Show Obsolete
(9)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-07-28 07:11:42 PDT
<
rdar://problem/66216190
>
Jonathan Bedard
Comment 2
2020-07-28 07:18:22 PDT
Created
attachment 405355
[details]
Patch
Aakash Jain
Comment 3
2020-07-28 07:24:39 PDT
Comment on
attachment 405355
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=405355&action=review
> Tools/BuildSlaveSupport/ews-build/config.json:392 > + "shortname": "mac-applesilicon",
This is somewhat long name to show in status-bubble.
> Tools/BuildSlaveSupport/ews-build/config.json:613 > + "shortname": "webkitpy-applesilicon",
This is too long name to show in status-bubble.
> Tools/BuildSlaveSupport/ews-build/config.json:616 > + "platform": "*",
Is it ok for bots with older OS (e.g.: Mojave) to process patches on this queue? If not, it's better to have "platform: mac-bigsur" here, so as to avoid accidentally connecting bots like webkit-misc here. Same for "WebKitPerl-AppleSilicon-Tests-EWS"
> Tools/BuildSlaveSupport/ews-build/config.json:621 > + "shortname": "webkitperl-applesilicon",
This is too long name to show in status-bubble.
Aakash Jain
Comment 4
2020-07-28 07:30:15 PDT
Comment on
attachment 405355
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=405355&action=review
> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:49 > + 'mac-applesilicon', 'webkitperl-applesilicon', 'webkitpy-applesilicon']
This list is sorted in the order of which bubbles appear in bugzilla. First builders and then testers. Let's move 'mac-applesilicon' appropriately.
Jonathan Bedard
Comment 5
2020-07-28 09:01:22 PDT
Created
attachment 405361
[details]
Patch
Aakash Jain
Comment 6
2020-07-28 11:16:05 PDT
Comment on
attachment 405361
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=405361&action=review
> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:48 > + 'bindings', 'jsc', 'jsc-armv7', 'jsc-mips', 'jsc-i386', 'webkitperl', 'webkitpy', 'services', 'webkitperl-AS', 'webkitpy-AS']
Let's put webkitpy-AS next to webkitpy, and webkitperl-AS next to webkitperl
> Tools/BuildSlaveSupport/ews-build/config.json:398 > + "triggers": [],
triggers can be removed from here.
> Tools/BuildSlaveSupport/ews-build/config.json:399 > + "workernames": ["ews129"]
One bot might not be enough for this queue. You may want to add ews130 as well in the config right away, and connect it when it's ready.
> Tools/BuildSlaveSupport/ews-build/config.json:683 > + "macOS-BigSur-Release-Build-EWS", "WebKitPerl-AppleSilicon-Tests-EWS", "WebKitPy-AppleSilicon-Tests-EWS"]
This list is in alphabetical order, let's maintain it that way.
Jonathan Bedard
Comment 7
2020-07-28 12:14:47 PDT
Created
attachment 405387
[details]
Patch
Jonathan Bedard
Comment 8
2020-07-28 12:16:38 PDT
Created
attachment 405389
[details]
Patch
Aakash Jain
Comment 9
2020-07-28 12:24:23 PDT
Comment on
attachment 405389
[details]
Patch Looks good. I am concerned that one bot might not be enough for "macOS-BigSur-Release-Build-EWS" (and also webkitpy-AS, webkitperl-AS queues). Let's land it only after testing it on uat instance and seeing if it's able to keep up with the patches.
Jonathan Bedard
Comment 10
2020-07-29 10:03:20 PDT
Created
attachment 405469
[details]
Patch
Jonathan Bedard
Comment 11
2020-07-29 14:25:59 PDT
Created
attachment 405502
[details]
Patch
Aakash Jain
Comment 12
2020-07-29 14:35:41 PDT
Comment on
attachment 405502
[details]
Patch r+ with the conflicts resolved. Please make sure to test new changes on uat instance as well.
Jonathan Bedard
Comment 13
2020-07-29 15:25:42 PDT
Created
attachment 405513
[details]
Patch
Jonathan Bedard
Comment 14
2020-07-29 15:42:43 PDT
Created
attachment 405518
[details]
Patch
Aakash Jain
Comment 15
2020-07-29 16:42:13 PDT
Comment on
attachment 405518
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=405518&action=review
> Tools/BuildSlaveSupport/ews-build/factories_unittest.py:174 > + factory = factories.macOSBuildOnlyFactory(platform='mac-bigsur', configuration='release', architectures=["x86_64", "arm64"])
architectures should be arm64 only.
> Tools/BuildSlaveSupport/ews-build/factories_unittest.py:176 > + _BuildStepFactory(steps.ConfigureBuild, platform='mac-bigsur', configuration='release', architectures=["x86_64", "arm64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
Maybe buildOnly should be true, but that can be done/tested in separate patch. That appends the flags DEBUG_INFORMATION_FORMAT=dwarf-with-dsym and CLANG_DEBUG_INFORMATION_LEVEL=line-tables-only to build-webkit command. Not sure how much is the impact.
Jonathan Bedard
Comment 16
2020-07-29 16:45:14 PDT
Created
attachment 405527
[details]
Patch for landing
Jonathan Bedard
Comment 17
2020-07-29 16:48:43 PDT
(In reply to Aakash Jain from
comment #15
)
> Comment on
attachment 405518
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=405518&action=review
> > > Tools/BuildSlaveSupport/ews-build/factories_unittest.py:174 > > + factory = factories.macOSBuildOnlyFactory(platform='mac-bigsur', configuration='release', architectures=["x86_64", "arm64"]) > > architectures should be arm64 only. > > > Tools/BuildSlaveSupport/ews-build/factories_unittest.py:176 > > + _BuildStepFactory(steps.ConfigureBuild, platform='mac-bigsur', configuration='release', architectures=["x86_64", "arm64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None), > > Maybe buildOnly should be true, but that can be done/tested in separate > patch. > That appends the flags DEBUG_INFORMATION_FORMAT=dwarf-with-dsym and > CLANG_DEBUG_INFORMATION_LEVEL=line-tables-only to build-webkit command. Not > sure how much is the impact.
Maybe, although we don't do that for iOS today, so that should be a separate patch to fix that for all effected platforms.
Jonathan Bedard
Comment 18
2020-07-29 17:14:08 PDT
Created
attachment 405531
[details]
Patch
EWS
Comment 19
2020-07-30 08:56:01 PDT
Committed
r265082
: <
https://trac.webkit.org/changeset/265082
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 405531
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug