Bug 214874 – Add EWS builder queue for Apple Silicon

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

We should defend the Seed 3 build, along with some basic tools tests, on Apple Silicon.

[Radar WebKit Bug Importer]

<rdar://problem/66216190>

[Jonathan Bedard]

Created attachment 405355 [details]
Patch

[Aakash Jain]

Comment on attachment 405355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405355&action=review

> Tools/BuildSlaveSupport/ews-build/config.json:392
> +      "shortname": "mac-applesilicon",

This is somewhat long name to show in status-bubble.

> Tools/BuildSlaveSupport/ews-build/config.json:613
> +      "shortname": "webkitpy-applesilicon",

This is too long name to show in status-bubble.

> Tools/BuildSlaveSupport/ews-build/config.json:616
> +      "platform": "*",

Is it ok for bots with older OS (e.g.: Mojave) to process patches on this queue? If not, it's better to have "platform: mac-bigsur" here, so as to avoid accidentally connecting bots like webkit-misc here. Same for "WebKitPerl-AppleSilicon-Tests-EWS"

> Tools/BuildSlaveSupport/ews-build/config.json:621
> +      "shortname": "webkitperl-applesilicon",

This is too long name to show in status-bubble.

[Aakash Jain]

Comment on attachment 405355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405355&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:49
> +                  'mac-applesilicon', 'webkitperl-applesilicon', 'webkitpy-applesilicon']

This list is sorted in the order of which bubbles appear in bugzilla. First builders and then testers. Let's move 'mac-applesilicon' appropriately.

[Jonathan Bedard]

Created attachment 405361 [details]
Patch

[Aakash Jain]

Comment on attachment 405361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405361&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:48
> +                  'bindings', 'jsc', 'jsc-armv7', 'jsc-mips', 'jsc-i386', 'webkitperl', 'webkitpy', 'services', 'webkitperl-AS', 'webkitpy-AS']

Let's put webkitpy-AS next to webkitpy, and webkitperl-AS next to webkitperl

> Tools/BuildSlaveSupport/ews-build/config.json:398
> +      "triggers": [],

triggers can be removed from here.

> Tools/BuildSlaveSupport/ews-build/config.json:399
> +      "workernames": ["ews129"]

One bot might not be enough for this queue. You may want to add ews130 as well in the config right away, and connect it when it's ready.

> Tools/BuildSlaveSupport/ews-build/config.json:683
> +                       "macOS-BigSur-Release-Build-EWS", "WebKitPerl-AppleSilicon-Tests-EWS", "WebKitPy-AppleSilicon-Tests-EWS"]

This list is in alphabetical order, let's maintain it that way.

[Jonathan Bedard]

Created attachment 405387 [details]
Patch

[Jonathan Bedard]

Created attachment 405389 [details]
Patch

[Aakash Jain]

Comment on attachment 405389 [details]
Patch

Looks good. I am concerned that one bot might not be enough for "macOS-BigSur-Release-Build-EWS" (and also webkitpy-AS, webkitperl-AS queues). Let's land it only after testing it on uat instance and seeing if it's able to keep up with the patches.

[Jonathan Bedard]

Created attachment 405469 [details]
Patch

[Jonathan Bedard]

Created attachment 405502 [details]
Patch

[Aakash Jain]

Comment on attachment 405502 [details]
Patch

r+ with the conflicts resolved. Please make sure to test new changes on uat instance as well.

[Jonathan Bedard]

Created attachment 405513 [details]
Patch

[Jonathan Bedard]

Created attachment 405518 [details]
Patch

[Aakash Jain]

Comment on attachment 405518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405518&action=review

> Tools/BuildSlaveSupport/ews-build/factories_unittest.py:174
> +        factory = factories.macOSBuildOnlyFactory(platform='mac-bigsur', configuration='release', architectures=["x86_64", "arm64"])

architectures should be arm64 only.

> Tools/BuildSlaveSupport/ews-build/factories_unittest.py:176
> +            _BuildStepFactory(steps.ConfigureBuild, platform='mac-bigsur', configuration='release', architectures=["x86_64", "arm64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),

Maybe buildOnly should be true, but that can be done/tested in separate patch.
That appends the flags DEBUG_INFORMATION_FORMAT=dwarf-with-dsym and CLANG_DEBUG_INFORMATION_LEVEL=line-tables-only to build-webkit command. Not sure how much is the impact.

[Jonathan Bedard]

Created attachment 405527 [details]
Patch for landing

[Jonathan Bedard]

(In reply to Aakash Jain from comment #15)
> Comment on attachment 405518 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405518&action=review
> 
> > Tools/BuildSlaveSupport/ews-build/factories_unittest.py:174
> > +        factory = factories.macOSBuildOnlyFactory(platform='mac-bigsur', configuration='release', architectures=["x86_64", "arm64"])
> 
> architectures should be arm64 only.
> 
> > Tools/BuildSlaveSupport/ews-build/factories_unittest.py:176
> > +            _BuildStepFactory(steps.ConfigureBuild, platform='mac-bigsur', configuration='release', architectures=["x86_64", "arm64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
> 
> Maybe buildOnly should be true, but that can be done/tested in separate
> patch.
> That appends the flags DEBUG_INFORMATION_FORMAT=dwarf-with-dsym and
> CLANG_DEBUG_INFORMATION_LEVEL=line-tables-only to build-webkit command. Not
> sure how much is the impact.

Maybe, although we don't do that for iOS today, so that should be a separate patch to fix that for all effected platforms.

[Jonathan Bedard]

Created attachment 405531 [details]
Patch

[EWS]

Committed r265082: <https://trac.webkit.org/changeset/265082>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405531 [details].