Bug 214867 - Add WebRTC tests exercising H264 with various resolutions and bitrates.
Summary: Add WebRTC tests exercising H264 with various resolutions and bitrates.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-28 02:18 PDT by youenn fablet
Modified: 2020-07-28 14:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (10.50 KB, patch)
2020-07-28 02:23 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (14.07 KB, patch)
2020-07-28 06:06 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (10.50 KB, patch)
2020-07-28 10:01 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-07-28 02:18:54 PDT
Add WebRTC tests exercising H264 with various resolutions and bitrates.
Comment 1 youenn fablet 2020-07-28 02:23:30 PDT
Created attachment 405346 [details]
Patch
Comment 2 youenn fablet 2020-07-28 06:06:54 PDT
Created attachment 405353 [details]
Patch
Comment 3 youenn fablet 2020-07-28 07:18:32 PDT
Comment on attachment 405353 [details]
Patch

Tests seem to run slowly so I had to increase timeout.
But it seems to run fine on EWS now.
If tests end up being flaky, we might have to split them in individual files.
Comment 4 Eric Carlson 2020-07-28 09:28:58 PDT
Comment on attachment 405353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405353&action=review

> LayoutTests/http/wpt/fetch/readableStreamDefaultController-overwriting-expected.txt:5
> +
> +PASS Overwrite ReadableStreamDefaultController enqueue 
> +PASS Overwrite ReadableStreamDefaultController error 
> +PASS Overwrite ReadableStreamDefaultController close 
> +

I don't think you meant to include this.

> LayoutTests/http/wpt/fetch/readableStreamDefaultController-overwriting.html:11
> +<!DOCTYPE html>
> +<script src='/resources/testharness.js'></script>
> +<script src='/resources/testharnessreport.js'></script>
> +<script>
> +
> +var controllerPrototype;
> +const rs = new ReadableStream({
> +    start: function(c) {
> +        controllerPrototype = Object.getPrototypeOf(c);
> +    }
> +});

Ditto

> LayoutTests/http/wpt/fetch/resources/lengthy-pass.py:7
> +import time
> +
> +def main(request, response):
> +    delay = 0.05
> +    headers = []
> +    if "delay" in request.GET:
> +        delay = float(request.GET.first("delay"))

Ditto.
Comment 5 youenn fablet 2020-07-28 10:01:10 PDT
Created attachment 405369 [details]
Patch for landing
Comment 6 youenn fablet 2020-07-28 10:01:28 PDT
> I don't think you meant to include this.

Indeed, I removed them.
Comment 7 EWS 2020-07-28 14:05:02 PDT
Committed r265005: <https://trac.webkit.org/changeset/265005>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405369 [details].
Comment 8 Radar WebKit Bug Importer 2020-07-28 14:06:17 PDT
<rdar://problem/66236337>