Bug 214845 - Occasional crashes under PDFPlugin::createScrollbar and PDFPlugin::updateScrollbars
Summary: Occasional crashes under PDFPlugin::createScrollbar and PDFPlugin::updateScro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-27 13:55 PDT by Tim Horton
Modified: 2020-07-27 14:57 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.27 KB, patch)
2020-07-27 14:03 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (4.25 KB, patch)
2020-07-27 14:16 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-07-27 13:55:49 PDT
Occasional crashes under PDFPlugin::createScrollbar and PDFPlugin::updateScrollbars
Comment 1 Tim Horton 2020-07-27 14:03:54 PDT
Created attachment 405309 [details]
Patch
Comment 2 Tim Horton 2020-07-27 14:03:56 PDT
<rdar://problem/59293598>
Comment 3 Brady Eidson 2020-07-27 14:06:08 PDT
Comment on attachment 405309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405309&action=review

> Source/WebKit/ChangeLog:11
> +        No new tests; timing is such that I can't reproduce without inserting
> +        intentional delays into the main thread hops, which is further than
> +        I'm willing to go for a test.

Fair.
Comment 4 Tim Horton 2020-07-27 14:16:00 PDT
Created attachment 405311 [details]
Patch
Comment 5 EWS 2020-07-27 14:57:20 PDT
Committed r264945: <https://trac.webkit.org/changeset/264945>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405311 [details].