Bug 214844 – [Big Sur] Wrap SPI in feature guards

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jonathan Bedard]

There is some Big Sur SPI declarations that should arguably be behind a feature flag.

[Radar WebKit Bug Importer]

<rdar://problem/66178527>

[Jonathan Bedard]

Created attachment 405306 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 405306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405306&action=review

> Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:39
>  extern const NSImageHintKey NSImageHintSymbolFont;

Pre-existing issue, but this shouldn't be in #else, correct? We want the compiler to tell us if the type is incorrect.

[Jonathan Bedard]

Created attachment 405307 [details]
Patch

[EWS]

Committed r264946: <https://trac.webkit.org/changeset/264946>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405307 [details].

[Saagar Jha]

Sadly, this moves the code out of the NS_ASSUME_NONNULL region and causes build errors :( I'll put up a new patch to move it back into.

[Jonathan Bedard]

Reopening to attach new patch.

[Jonathan Bedard]

Created attachment 405413 [details]
Patch for landing

[Jonathan Bedard]

(In reply to Saagar Jha from comment #6)
> Sadly, this moves the code out of the NS_ASSUME_NONNULL region and causes
> build errors :( I'll put up a new patch to move it back into.

Oops! Build fix incoming. Bots will be up for Seed 3 shortly, so we'll be more formally defending this build.

[EWS]

Committed r265010: <https://trac.webkit.org/changeset/265010>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405413 [details].