Bug 214825 – Remember to check entitlement before communicating over XPC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

Remember to check entitlement before communicating over XPC with another WebKit process. This needs to be done to make sure that it really is a WebKit process on the other end.

[Per Arne Vollan]

Created attachment 405271 [details]
Patch

[Per Arne Vollan]

Created attachment 405366 [details]
Patch

[Per Arne Vollan]

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 405410 [details]
Patch

[Per Arne Vollan]

Created attachment 405453 [details]
Patch

[Brent Fulgham]

Comment on attachment 405453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405453&action=review

R=me

> Source/WebKit/Shared/Cocoa/XPCEndpoint.mm:47
> +                WTFLogAlways("Audit token does not have required entitlement");

Should we just say what entitlement in the error message?

[Per Arne Vollan]

Created attachment 405569 [details]
Patch

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #6)
> Comment on attachment 405453 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405453&action=review
> 
> R=me
> 
> > Source/WebKit/Shared/Cocoa/XPCEndpoint.mm:47
> > +                WTFLogAlways("Audit token does not have required entitlement");
> 
> Should we just say what entitlement in the error message?

Fixed.

Thanks for reviewing!

[EWS]

Committed r265087: <https://trac.webkit.org/changeset/265087>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405569 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66331689>