Bug 214818 - Check m_connection in NetworkRTCProvider::createResolver/stopResolver
Summary: Check m_connection in NetworkRTCProvider::createResolver/stopResolver
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Keywords: InRadar
Depends on:
Reported: 2020-07-27 00:58 PDT by youenn fablet
Modified: 2020-07-27 08:10 PDT (History)
4 users (show)

See Also:

Patch (1.94 KB, patch)
2020-07-27 01:00 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (1.94 KB, patch)
2020-07-27 07:35 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-07-27 00:58:10 PDT
Check m_connection in NetworkRTCProvider::createResolver/stopResolver
Comment 1 youenn fablet 2020-07-27 01:00:31 PDT
Created attachment 405262 [details]
Comment 2 Eric Carlson 2020-07-27 07:16:22 PDT
Comment on attachment 405262 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=405262&action=review

> Source/WebKit/ChangeLog:8
> +        We need to check for m_connection when hopping to main thread as the NetworkRTCProvider might get closed otherwise.

s/might get closed otherwise/might already be closed/
Comment 3 youenn fablet 2020-07-27 07:35:51 PDT
Created attachment 405272 [details]
Comment 4 EWS 2020-07-27 08:09:45 PDT
Committed r264922: <https://trac.webkit.org/changeset/264922>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405272 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-27 08:10:16 PDT