Bug 214807 – [Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting.

[Jer Noble]

Created attachment 405255 [details]
Patch

[Darin Adler]

Comment on attachment 405255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405255&action=review

> Source/WebCore/ChangeLog:16
> +        * platform/graphics/cocoa/VP9UtilitiesCocoa.h:
> +        * platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
> +        (WebCore::registerWebKitVP9Decoder):

I would have left the word "utilities" out of this file’s name.

> Source/WebCore/SourcesCocoa.txt:359
> +platform/graphics/cocoa/VP9UtilitiesCocoa.mm @no-unify

Is this *really* necessary? Why?

[Jer Noble]

(In reply to Darin Adler from comment #2)
> Comment on attachment 405255 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405255&action=review
> 
> > Source/WebCore/ChangeLog:16
> > +        * platform/graphics/cocoa/VP9UtilitiesCocoa.h:
> > +        * platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
> > +        (WebCore::registerWebKitVP9Decoder):
> 
> I would have left the word "utilities" out of this file’s name.
> 
> > Source/WebCore/SourcesCocoa.txt:359
> > +platform/graphics/cocoa/VP9UtilitiesCocoa.mm @no-unify
> 
> Is this *really* necessary? Why?

Yes. Some header in CoreServices adds `a #define kName ...`, which causes a compilation error when a header inside WebRTC defines variable with that same name. And the CoreServices header just happens to be pulled into the unified build by some sibling source file.

[EWS]

Committed r265095: <https://trac.webkit.org/changeset/265095>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405255 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66347767>