Bug 214807 - [Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting.
Summary: [Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-26 11:43 PDT by Jer Noble
Modified: 2020-07-30 14:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (20.95 KB, patch)
2020-07-26 11:52 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-07-26 11:43:26 PDT 
[Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting.
Comment 1 Jer Noble 2020-07-26 11:52:23 PDT 
Created attachment 405255 [details]
Patch
Comment 2 Darin Adler 2020-07-26 11:58:37 PDT 
Comment on attachment 405255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405255&action=review

> Source/WebCore/ChangeLog:16
> +        * platform/graphics/cocoa/VP9UtilitiesCocoa.h:
> +        * platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
> +        (WebCore::registerWebKitVP9Decoder):

I would have left the word "utilities" out of this file’s name.

> Source/WebCore/SourcesCocoa.txt:359
> +platform/graphics/cocoa/VP9UtilitiesCocoa.mm @no-unify

Is this *really* necessary? Why?
Comment 3 Jer Noble 2020-07-26 22:34:06 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 405255 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405255&action=review
> 
> > Source/WebCore/ChangeLog:16
> > +        * platform/graphics/cocoa/VP9UtilitiesCocoa.h:
> > +        * platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
> > +        (WebCore::registerWebKitVP9Decoder):
> 
> I would have left the word "utilities" out of this file’s name.
> 
> > Source/WebCore/SourcesCocoa.txt:359
> > +platform/graphics/cocoa/VP9UtilitiesCocoa.mm @no-unify
> 
> Is this *really* necessary? Why?

Yes. Some header in CoreServices adds `a #define kName ...`, which causes a compilation error when a header inside WebRTC defines variable with that same name. And the CoreServices header just happens to be pulled into the unified build by some sibling source file.
Comment 4 EWS 2020-07-30 14:28:43 PDT 
Committed r265095: <https://trac.webkit.org/changeset/265095>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405255 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-30 14:29:18 PDT 
<rdar://problem/66347767>