Bug 214806 – libwebrtc uint64_t build fixes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Michael Catanzaro]

WebKitGTK currently fails to build with -DENABLE_EXPERIMENTAL_FEATURES=ON because a bunch of libwebrtc headers use integer typedefs without declaring them:

In file included from ../../Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h264/pps_parser.cc:11:
../../Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h264/pps_parser.h:33:5: error: ‘uint32_t’ does not name a type; did you mean ‘u_int32_t’?
   33 |     uint32_t weighted_bipred_idc = false;
      |     ^~~~~~~~
      |     u_int32_t

[Michael Catanzaro]

Created attachment 405252 [details]
Patch

[Michael Catanzaro]

(I wonder if anyone here has an account on libwebrtc's gerrit and would be willing to send it upstream...?)

[Michael Catanzaro]

Created attachment 405253 [details]
Patch

[youenn fablet]

Would be good to upstream otherwise this might get overwritten at next resync.

[EWS]

Committed r264904: <https://trac.webkit.org/changeset/264904>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405253 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66133368>

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #2)
> (I wonder if anyone here has an account on libwebrtc's gerrit and would be
> willing to send it upstream...?)

[youenn fablet]

(In reply to youenn fablet from comment #4)
> Would be good to upstream otherwise this might get overwritten at next
> resync.

As per https://bugs.webkit.org/show_bug.cgi?id=218436, this actually happened.
If you cannot upstream the changes, please add #if defined(WEBRTC_WEBKIT_BUILD) so that there is a chance to keep these changes at next resync.

[Michael Catanzaro]

OK