Bug 21480 - PluginInfo and MimeTypeInfo structs are defined in two header files used on windows
Summary: PluginInfo and MimeTypeInfo structs are defined in two header files used on w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-08 11:25 PDT by Tony Chang
Modified: 2008-10-12 18:13 PDT (History)
0 users

See Also:


Attachments
[1/1] Remove duplicate definitions of MimeTypeInfo and PluginInfo. (1.50 KB, patch)
2008-10-08 11:26 PDT, Tony Chang
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2008-10-08 11:25:38 PDT
They're defined in PluginData.h and PluginInfoStore.h.  There should be only one.  Patch coming.
Comment 1 Tony Chang 2008-10-08 11:26:23 PDT
Created attachment 24193 [details]
[1/1] Remove duplicate definitions of MimeTypeInfo and PluginInfo.

They're already defined in PluginData.h.
---
 WebCore/ChangeLog                   |   11 +++++++++++
 WebCore/plugins/PluginInfoStore.cpp |    1 +
 WebCore/plugins/PluginInfoStore.h   |   14 --------------
 3 files changed, 12 insertions(+), 14 deletions(-)
Comment 2 Sam Weinig 2008-10-08 13:46:34 PDT
Comment on attachment 24193 [details]
[1/1] Remove duplicate definitions of MimeTypeInfo and PluginInfo.

Nice.
Comment 3 Darin Adler 2008-10-12 18:13:44 PDT
http://trac.webkit.org/changeset/37541