Bug 214708 - KeyframeEffect doesn't update after changing timing function
Summary: KeyframeEffect doesn't update after changing timing function
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-23 15:51 PDT by Simon Fraser (smfr)
Modified: 2020-07-31 08:39 PDT (History)
4 users (show)

See Also:

Attachments
test (2.30 KB, text/html)
2020-07-23 15:51 PDT, Simon Fraser (smfr) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-07-23 15:51:01 PDT 
Created attachment 405088 [details]
test

In the attached test, hover the spinner. This should change the timing function, but the same KeyframeEffect persists, and KeyframeEffect::computeSomeKeyframesUseStepsTimingFunction() is never called.
Comment 1 Simon Fraser (smfr) 2020-07-23 16:02:16 PDT 
KeyframeEffect::animationDidChangeTimingProperties() needs to call computeSomeKeyframesUseStepsTimingFunction().
Comment 2 Radar WebKit Bug Importer 2020-07-30 15:51:18 PDT 
<rdar://problem/66351796>
Comment 3 Antoine Quint 2020-07-31 04:20:27 PDT 
The attached test works fine for me on a ToT build on macOS. When the spinner is not hovered, it progresses very slowly step-by-step while when it's hovered it has a linear animation. I didn't see any obvious difference between its behavior on a ToT build and recent Firefox and Chrome.
Comment 4 Simon Fraser (smfr) 2020-07-31 08:39:27 PDT 
https://trac.webkit.org/changeset/264856/webkit fixed this.