Bug 214705 - Tapping QuickType suggestions for a misspelled word does nothing in Mail compose
Summary: Tapping QuickType suggestions for a misspelled word does nothing in Mail compose
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-23 15:13 PDT by Wenson Hsieh
Modified: 2020-07-23 22:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.14 KB, patch)
2020-07-23 15:37 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix non-internal iOS build (16.67 KB, patch)
2020-07-23 15:45 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Minor tweaks (19.33 KB, patch)
2020-07-23 16:33 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix API test (19.64 KB, patch)
2020-07-23 18:01 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix API test (19.91 KB, patch)
2020-07-23 20:20 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-07-23 15:13:56 PDT 
<rdar://problem/58320785>
Comment 1 Wenson Hsieh 2020-07-23 15:37:58 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2020-07-23 15:45:26 PDT 
Created attachment 405086 [details]
Fix non-internal iOS build
Comment 3 Tim Horton 2020-07-23 15:52:57 PDT 
Comment on attachment 405086 [details]
Fix non-internal iOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=405086&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1770
> +        completionHandler();

Does this want some kind of call-at-exit thing? (I feel like we have one, but not sure what it's called)
Comment 4 Darin Adler 2020-07-23 16:00:04 PDT 
Comment on attachment 405086 [details]
Fix non-internal iOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=405086&action=review

>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1770
>> +        completionHandler();
> 
> Does this want some kind of call-at-exit thing? (I feel like we have one, but not sure what it's called)

makeScopeExit
Comment 5 Wenson Hsieh 2020-07-23 16:00:53 PDT 
(In reply to Darin Adler from comment #4)
> Comment on attachment 405086 [details]
> Fix non-internal iOS build
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405086&action=review
> 
> >> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1770
> >> +        completionHandler();
> > 
> > Does this want some kind of call-at-exit thing? (I feel like we have one, but not sure what it's called)
> 
> makeScopeExit

👍🏻
Comment 6 Wenson Hsieh 2020-07-23 16:33:54 PDT 
Created attachment 405095 [details]
Minor tweaks
Comment 7 Wenson Hsieh 2020-07-23 18:01:47 PDT 
Created attachment 405107 [details]
Fix API test
Comment 8 Wenson Hsieh 2020-07-23 20:20:58 PDT 
Created attachment 405122 [details]
Fix API test
Comment 9 EWS 2020-07-23 22:32:00 PDT 
Committed r264812: <https://trac.webkit.org/changeset/264812>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405122 [details].