Bug 214692 – Update the isolated tree even when there is no client request.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

Update the isolated tree even when there is no client request.

[Andres Gonzalez]

Created attachment 405060 [details]
Patch

[chris fleizach]

Comment on attachment 405060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405060&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:3196
> +    case AXLoadingFinished:

can we change this method so it doesn't duplicate the logic in the other updateIsolateTree method? instead do something like

void AXObjectCache::updateIsolatedTree(AXCoreObject& object, AXLoadingEvent notification)
{
   if (notification == AXLoadingFinished)
    updateIsoaltedTree(object, AXChildrenChanged)
}

[Andres Gonzalez]

Created attachment 405064 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #2)
> Comment on attachment 405060 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405060&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:3196
> > +    case AXLoadingFinished:
> 
> can we change this method so it doesn't duplicate the logic in the other
> updateIsolateTree method? instead do something like
> 
> void AXObjectCache::updateIsolatedTree(AXCoreObject& object, AXLoadingEvent
> notification)
> {
>    if (notification == AXLoadingFinished)
>     updateIsoaltedTree(object, AXChildrenChanged)
> }

Done as suggested. Also pondered the approach of merging the AXLoadingEvent enum into AXNotification. But don't know why it was added as a separate enum, and it would require more changes. Something perhaps for a later cleanup. Thanks.

[EWS]

Committed r264784: <https://trac.webkit.org/changeset/264784>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405064 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66007855>