Bug 214676 - [JSC] Do not use hardened Array for Intl supportedLocalesOf
Summary: [JSC] Do not use hardened Array for Intl supportedLocalesOf
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 213425
  Show dependency tree / graph
 
Reported: 2020-07-23 01:09 PDT by Yusuke Suzuki
Modified: 2020-07-24 08:50 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.77 KB, patch)
2020-07-23 01:41 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-07-23 01:09:52 PDT 
https://github.com/tc39/ecma402/pull/278
Comment 1 Yusuke Suzuki 2020-07-23 01:41:41 PDT 
Created attachment 405023 [details]
Patch
Comment 2 Caio Lima 2020-07-23 05:36:57 PDT 
Comment on attachment 405023 [details]
Patch

Informal r+. This patch LGTM, but I have one question regarding Test262. Is this making some Test262 cases pass? If so, is it possible to update test expectations?
Comment 3 Mark Lam 2020-07-23 06:30:42 PDT 
Comment on attachment 405023 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2020-07-23 22:04:30 PDT 
(In reply to Caio Lima from comment #2)
> Comment on attachment 405023 [details]
> Patch
> 
> Informal r+. This patch LGTM, but I have one question regarding Test262. Is
> this making some Test262 cases pass? If so, is it possible to update test
> expectations?

Because https://trac.webkit.org/changeset/260349/webkit changed observable part, this does not affect on test262. This eliminates non observable but time-consuming + meaningless code.
Comment 5 EWS 2020-07-24 08:49:55 PDT 
Committed r264827: <https://trac.webkit.org/changeset/264827>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405023 [details].
Comment 6 Radar WebKit Bug Importer 2020-07-24 08:50:46 PDT 
<rdar://problem/66055863>