WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 214671
[CMake][Win] Build StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm only for AppleWin
https://bugs.webkit.org/show_bug.cgi?id=214671
Summary
[CMake][Win] Build StructuredExceptionHandlerSuppressor.cpp and makesafeseh.a...
Fujii Hironori
Reported
2020-07-22 19:25:38 PDT
[CMake][Win] Build StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm only for AppleWin StructuredExceptionHandlerSuppressor is used only by AppleWin port (in Source/WebCore/platform/graphics/ca/win/LayerChangesFlusher.cpp) makesafeseh.asm causes building problem for WinCairo because it is using OBJECT library type for WebCore.
Attachments
Patch
(3.27 KB, patch)
2020-07-22 19:29 PDT
,
Fujii Hironori
pvollan
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Fujii Hironori
Comment 1
2020-07-22 19:29:52 PDT
Created
attachment 405009
[details]
Patch
Per Arne Vollan
Comment 2
2020-07-23 07:12:30 PDT
Comment on
attachment 405009
[details]
Patch R=me.
Fujii Hironori
Comment 3
2020-07-23 13:38:19 PDT
Thank you for the review. Committed
r264786
: <
https://trac.webkit.org/r264786
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug