Bug 214671 - [CMake][Win] Build StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm only for AppleWin
Summary: [CMake][Win] Build StructuredExceptionHandlerSuppressor.cpp and makesafeseh.a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-22 19:25 PDT by Fujii Hironori
Modified: 2020-07-23 13:38 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.27 KB, patch)
2020-07-22 19:29 PDT, Fujii Hironori 		pvollan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-07-22 19:25:38 PDT 
[CMake][Win] Build StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm only for AppleWin

StructuredExceptionHandlerSuppressor is used only by AppleWin port (in Source/WebCore/platform/graphics/ca/win/LayerChangesFlusher.cpp)
makesafeseh.asm causes building problem for WinCairo because it is using OBJECT library type for WebCore.
Comment 1 Fujii Hironori 2020-07-22 19:29:52 PDT 
Created attachment 405009 [details]
Patch
Comment 2 Per Arne Vollan 2020-07-23 07:12:30 PDT 
Comment on attachment 405009 [details]
Patch

R=me.
Comment 3 Fujii Hironori 2020-07-23 13:38:19 PDT 
Thank you for the review.

Committed r264786: <https://trac.webkit.org/r264786>