Bug 214668 - Fix missing exception checks below RTCPeerConnection.generateCertificate().
Summary: Fix missing exception checks below RTCPeerConnection.generateCertificate().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-22 17:55 PDT by Mark Lam
Modified: 2020-07-23 01:49 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch. (16.38 KB, patch)
2020-07-22 18:16 PDT, Mark Lam
ysuzuki: review+
Details | Formatted Diff | Diff
proposed patch. (21.75 KB, patch)
2020-07-22 19:47 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (21.80 KB, patch)
2020-07-22 21:29 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-07-22 17:55:43 PDT
<rdar://problem/65929975>
Comment 1 Mark Lam 2020-07-22 18:16:06 PDT
Created attachment 405005 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2020-07-22 18:23:24 PDT
Comment on attachment 405005 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2020-07-22 19:47:53 PDT
Created attachment 405010 [details]
proposed patch.

Previous fix has a bug.  Let's try this new one on the EWS.
Comment 4 Mark Lam 2020-07-22 21:29:02 PDT
Created attachment 405016 [details]
proposed patch.
Comment 5 Mark Lam 2020-07-22 22:16:54 PDT
Comment on attachment 405016 [details]
proposed patch.

EWS bots are green.  This is ready for a review.
Comment 6 Yusuke Suzuki 2020-07-22 22:21:25 PDT
Comment on attachment 405016 [details]
proposed patch.

r=me
Comment 7 Yusuke Suzuki 2020-07-23 01:43:48 PDT
Comment on attachment 405016 [details]
proposed patch.

Looks like EWS is green!
Comment 8 EWS 2020-07-23 01:49:46 PDT
Committed r264751: <https://trac.webkit.org/changeset/264751>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405016 [details].