Bug 214653 - Update macOS Version macros
Summary: Update macOS Version macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Conrad Shultz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-22 13:56 PDT by Conrad Shultz
Modified: 2020-07-23 18:40 PDT (History)
18 users (show)

See Also:


Attachments
Patch (61.95 KB, patch)
2020-07-22 14:16 PDT, Conrad Shultz
no flags Details | Formatted Diff | Diff
Patch (96.85 KB, patch)
2020-07-22 15:25 PDT, Conrad Shultz
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Shultz 2020-07-22 13:56:13 PDT
Update macOS version macros.
Comment 1 Conrad Shultz 2020-07-22 13:56:52 PDT
<rdar://problem/65929542>
Comment 2 Conrad Shultz 2020-07-22 14:16:10 PDT
Created attachment 404960 [details]
Patch
Comment 3 EWS Watchlist 2020-07-22 14:17:10 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Conrad Shultz 2020-07-22 15:25:22 PDT
Created attachment 404983 [details]
Patch
Comment 5 Tim Horton 2020-07-22 15:26:47 PDT
Comment on attachment 404983 [details]
Patch

This is somewhere between rs=me and r=me.
Comment 6 Conrad Shultz 2020-07-22 21:49:08 PDT
Committed r264746: <https://trac.webkit.org/changeset/264746>
Comment 7 Alexey Proskuryakov 2020-07-23 17:41:52 PDT
Comment on attachment 404983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404983&action=review

> Source/JavaScriptCore/Configurations/Base.xcconfig:109
>  TARGET_MAC_OS_X_VERSION_MAJOR_10_16 = 101600;

Do we still need these?
Comment 8 Conrad Shultz 2020-07-23 18:40:52 PDT
(In reply to Alexey Proskuryakov from comment #7)
> Comment on attachment 404983 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404983&action=review
> 
> > Source/JavaScriptCore/Configurations/Base.xcconfig:109
> >  TARGET_MAC_OS_X_VERSION_MAJOR_10_16 = 101600;
> 
> Do we still need these?

I'm leaving them in for now in case anyone builds on, e.g., the first seed of Big Sur. I'd think we can remove them in due course.