Bug 214649 - updateRendering trace point should exclude SVG
Summary: updateRendering trace point should exclude SVG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 214691 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-22 12:12 PDT by Ben Nham
Modified: 2020-07-23 11:26 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2020-07-23 10:32 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2020-07-22 12:12:15 PDT 
After r259830, the updateRendering tracepoint doesn't work as expected since we are calling the tracepoint reentrantly (the root page's Page::updateRendering calls the SVG page's Page::updateRendering). We should either exclude the SVG page from this tracepoint or change the tracepoint pass an extra arg to kdebug_trace that can be used to properly pair the beginning and end of the tracepoint.
Comment 1 Simon Fraser (smfr) 2020-07-23 10:31:50 PDT 
*** Bug 214691 has been marked as a duplicate of this bug. ***
Comment 2 Simon Fraser (smfr) 2020-07-23 10:32:25 PDT 
Created attachment 405055 [details]
Patch
Comment 3 Geoffrey Garen 2020-07-23 10:34:37 PDT 
Comment on attachment 405055 [details]
Patch

r=me
Comment 4 EWS 2020-07-23 11:25:25 PDT 
Committed r264778: <https://trac.webkit.org/changeset/264778>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405055 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-23 11:26:17 PDT 
<rdar://problem/66002353>