Bug 214641 - [32-bits] Fixing the return of doVMEntry into LowLevelInterpreter32_64.asm
Summary: [32-bits] Fixing the return of doVMEntry into LowLevelInterpreter32_64.asm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-22 07:29 PDT by Caio Lima
Modified: 2020-07-23 05:52 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.54 KB, patch)
2020-07-22 07:36 PDT, Caio Lima
no flags Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2020-07-23 05:03 PDT, Caio Lima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2020-07-22 07:29:35 PDT
...
Comment 1 Caio Lima 2020-07-22 07:36:40 PDT
Created attachment 404921 [details]
Patch
Comment 2 Mark Lam 2020-07-22 08:29:15 PDT
Comment on attachment 404921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404921&action=review

r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:331
> +    move UndefinedTag, r1
> +    move 0, r0

Can you just put a comment above this that says that this is in little endian order?  That will make it easier if anyone tries to make big endian work, and need to grep for search for places to make needed changes.  A comment is cheap and can be so helpful here.
Comment 3 Caio Lima 2020-07-23 05:03:05 PDT
Created attachment 405033 [details]
Patch
Comment 4 Caio Lima 2020-07-23 05:06:53 PDT
Comment on attachment 405033 [details]
Patch

Thank you very much for the review. I also added another comment in another place that is "little-endian" specific.
Comment 5 EWS 2020-07-23 05:51:56 PDT
Committed r264758: <https://trac.webkit.org/changeset/264758>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405033 [details].
Comment 6 Radar WebKit Bug Importer 2020-07-23 05:52:18 PDT
<rdar://problem/65987760>