Bug 214636 – [GStreamer] media/media-source/media-source-webm.html is failing or crashing since added in r264685

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Diego Pino]

media/media-source/media-source-webm.html [ Failure ]

Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r264693%20(14817)/media/media-source/media-source-webm-diff.txt

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/media-source/media-source-webm-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/media-source/media-source-webm-actual.txt
@@ -5,9 +5,6 @@
 RUN(source.duration = loader.duration())
 RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
 RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
 EVENT(resize)
 EXPECTED (video.videoWidth == '320') OK
 EXPECTED (video.videoHeight == '240') OK

[Lauro Moura]

r265273 changed this test to be promise-based. Now the missing 'update' event entry is present but the test times out waiting for the resize event.

Debugging shows an initial resize event being raised with the final video resolution (320x240), but before the update event on the sourceBuffer is raised to continue the test.

Subsequent calls to HTMLVideoElement::scheduleResizeEventIfSizeChanged happen with no size change, skipping the resize event.

[Carlos Alberto Lopez Perez]

This test is also crashing sometimes

On the runs for the last 4000 revisions (from r264991 to r268991) it
 crashed 8 times in the GTK release test bot
 crashed 18 times in the WPE debug test bot
 crashed 111 times in the GTK debug test bot

On the last crash for GTK debug (r268968) is hitting an assertion:



STDERR: ASSERTION FAILED: !intrinsicSizeChanged || !view().frameView().layoutContext().isInRenderTreeLayout()
STDERR: ../../Source/WebCore/rendering/RenderVideo.cpp(261) : void WebCore::RenderVideo::updatePlayer()
STDERR: 1   0x7f07344a7749 WTFCrash
STDERR: 2   0x7f0740ec6efb /app/webkit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb2feefb) [0x7f0740ec6efb]
STDERR: 3   0x7f0745879330 WebCore::RenderVideo::updatePlayer()
STDERR: 4   0x7f074587925e WebCore::RenderVideo::layout()
STDERR: 5   0x7f07455525ac WebCore::RenderElement::layoutIfNeeded()
STDERR: 6   0x7f074554900e WebCore::ComplexLineLayout::layoutLineBoxes(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&)
STDERR: 7   0x7f074560f56e WebCore::RenderBlockFlow::layoutInlineChildren(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&)
STDERR: 8   0x7f074560e6d9 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit)
STDERR: 9   0x7f07455f56e9 WebCore::RenderBlock::layout()
STDERR: 10  0x7f0745610e92 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&)
STDERR: 11  0x7f074560f7e4 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&)
STDERR: 12  0x7f074560e6f6 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit)
STDERR: 13  0x7f07455f56e9 WebCore::RenderBlock::layout()
STDERR: 14  0x7f0745610e92 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&)
STDERR: 15  0x7f074560f7e4 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&)
STDERR: 16  0x7f074560e6f6 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit)
STDERR: 17  0x7f07455f56e9 WebCore::RenderBlock::layout()
STDERR: 18  0x7f0745610e92 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&)
STDERR: 19  0x7f074560f7e4 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&)
STDERR: 20  0x7f074560e6f6 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit)
STDERR: 21  0x7f07455f56e9 WebCore::RenderBlock::layout()
STDERR: 22  0x7f074587a7c3 WebCore::RenderView::layout()
STDERR: 23  0x7f0744f832e1 WebCore::FrameViewLayoutContext::layout()
STDERR: 24  0x7f0744f9c2ff WebCore::FrameViewLayoutContext::layoutTimerFired()
STDERR: 25  0x7f0744fcab37 void std::__invoke_impl<void, void (WebCore::FrameViewLayoutContext::*&)(), WebCore::FrameViewLayoutContext*&>(std::__invoke_memfun_deref, void (WebCore::FrameViewLayoutContext::*&)(), WebCore::FrameViewLayoutContext*&)
STDERR: 26  0x7f0744fcaa62 std::__invoke_result<void (WebCore::FrameViewLayoutContext::*&)(), WebCore::FrameViewLayoutContext*&>::type std::__invoke<void (WebCore::FrameViewLayoutContext::*&)(), WebCore::FrameViewLayoutContext*&>(void (WebCore::FrameViewLayoutContext::*&)(), WebCore::FrameViewLayoutContext*&)
STDERR: 27  0x7f0744fcaa26 void std::_Bind<void (WebCore::FrameViewLayoutContext::*(WebCore::FrameViewLayoutContext*))()>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>)
STDERR: 28  0x7f0744fca9d6 void std::_Bind<void (WebCore::FrameViewLayoutContext::*(WebCore::FrameViewLayoutContext*))()>::operator()<, void>()
STDERR: 29  0x7f0744fca8fe WTF::Detail::CallableWrapper<std::_Bind<void (WebCore::FrameViewLayoutContext::*(WebCore::FrameViewLayoutContext*))()>, void>::call()
STDERR: 30  0x7f0740ec5b32 WTF::Function<void ()>::operator()() const
STDERR: 31  0x7f074171375e WebCore::Timer::fired()
STDERR: LEAK: 1 WebPageProxy

https://build.webkit.org/results/GTK-Linux-64-bit-Debug-Tests/r268968%20(7560)/media/media-source/media-source-webm-crash-log.txt

[Carlos Alberto Lopez Perez]

Updated expectations in r269021

[Alicia Boya García]

Created attachment 416587 [details]
Patch

[Alicia Boya García]

Comment on attachment 416587 [details]
Patch

I uploaded the patch to the wrong Bugzilla issue. Should be: https://bugs.webkit.org/show_bug.cgi?id=220046

[Alicia Boya García]

Should be fixed by https://bugs.webkit.org/show_bug.cgi?id=220046