Bug 214628 – Tapped DataDetected links present sub-menus from the wrong location.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Tapped DataDetected links present sub-menus from the wrong location.

[Megan Gardner]

Created attachment 404905 [details]
Patch

[Megan Gardner]

<rdar://problem/64808642>

[Wenson Hsieh]

Comment on attachment 404905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404905&action=review

> Source/WebKit/ChangeLog:12
> +        Setting this bit ensures that all the necessary data is calculated and returned
> +        when a DataDetector link is tapped.

Just curious — where is the logic that uses this linkIndicator information?

[Megan Gardner]

Comment on attachment 404905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404905&action=review

>> Source/WebKit/ChangeLog:12
>> +        when a DataDetector link is tapped.
> 
> Just curious — where is the logic that uses this linkIndicator information?

It's the bailout condition at the top of linkIndicatorPositionInformation in WebPageIOS, which in this case we do not want to bail out of, so that sourceRect = _positionInformation->linkIndicator.textBoundingRectInRootViewCoordinates gives good date when sending a source rect to DD.

[EWS]

Committed r264699: <https://trac.webkit.org/changeset/264699>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404905 [details].

[Tim Horton]

Heh, this is a slightly heavyweight solution (because it involves needless snapshotting), but it will do the trick for now, until we split positionInformation up into more bite-sized chunks.