Bug 214626 - REGRESSION(r205826): narrowNoBreakSpace (U+202F) has zero width, regardless of font
Summary: REGRESSION(r205826): narrowNoBreakSpace (U+202F) has zero width, regardless o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-21 21:27 PDT by Myles C. Maxfield
Modified: 2020-07-22 11:28 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.60 KB, patch)
2020-07-21 21:31 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (5.68 KB, patch)
2020-07-21 23:43 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2020-07-21 21:27:18 PDT
From static void overrideControlCharacters() in Font.cpp:

overwriteCodePoint(narrowNoBreakSpace, zeroWidthSpace);

This is bogus.

Also, this is becoming much more prominent now because a lot of the French unit formatting data in CLDR - and hence in e.g. NSMeasurementFormatter - uses 202F between numeric value and unit, e.g. "37 km"

It works in native content on macOS, and in all other browsers on macOS, but not in WebKit.
Comment 1 Myles C. Maxfield 2020-07-21 21:27:31 PDT
<rdar://problem/65193790>
Comment 2 Myles C. Maxfield 2020-07-21 21:31:51 PDT
Created attachment 404899 [details]
Patch
Comment 3 Myles C. Maxfield 2020-07-21 23:43:45 PDT
Created attachment 404903 [details]
Patch
Comment 4 EWS 2020-07-22 11:28:36 PDT
Committed r264714: <https://trac.webkit.org/changeset/264714>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404903 [details].