Bug 214619 - Web Inspector: inspector/canvas/memory.html is failing on macOS Apple Silicon
Summary: Web Inspector: inspector/canvas/memory.html is failing on macOS Apple Silicon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-21 15:53 PDT by BJ Burg
Modified: 2020-07-21 17:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.34 KB, patch)
2020-07-21 16:03 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2020-07-21 15:53:17 PDT 
.
Comment 1 BJ Burg 2020-07-21 15:53:34 PDT 
<rdar://65747521>
Comment 2 BJ Burg 2020-07-21 16:03:35 PDT 
Created attachment 404870 [details]
Patch
Comment 3 Devin Rousso 2020-07-21 16:07:09 PDT 
Comment on attachment 404870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404870&action=review

r=me

> LayoutTests/inspector/canvas/memory.html:59
> +                InspectorTest.expectGreaterThan(event.target.memoryCost, isNaN(initialMemoryCost) ? 0 : initialMemoryCost, "Memory cost should increase upon initially resizing canvas.");

NIT: this shouldn't be `NaN`, but I suppose it couldn't hurt to check
Comment 4 BJ Burg 2020-07-21 16:54:28 PDT 
Comment on attachment 404870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404870&action=review

>> LayoutTests/inspector/canvas/memory.html:59
>> +                InspectorTest.expectGreaterThan(event.target.memoryCost, isNaN(initialMemoryCost) ? 0 : initialMemoryCost, "Memory cost should increase upon initially resizing canvas.");
> 
> NIT: this shouldn't be `NaN`, but I suppose it couldn't hurt to check

It.. is. see expected results for the first test case.
Comment 5 EWS 2020-07-21 17:10:04 PDT 
Committed r264683: <https://trac.webkit.org/changeset/264683>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404870 [details].