Bug 214618 – [IPC hardening] WebKit::ObjCObjectGraph::decode() and encode() should use enum ObjCType type

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[David Kilzer (:ddkilzer)]

WebKit::ObjCObjectGraph::decode() and encode() should use enum ObjCType type.

We can also get rid of default: case labels while we're here to make -Wimplicit-fallthrough emit a warning when a new enum is added.

<rdar://problem/65777899>

[David Kilzer (:ddkilzer)]

Created attachment 404875 [details]
Patch v1

[youenn fablet]

Comment on attachment 404875 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=404875&action=review

> Source/WebKit/Shared/mac/ObjCObjectGraph.mm:178
> +    }

No need for { }.
Ditto below.

> Source/WebKit/Shared/mac/ObjCObjectGraph.mm:252
> +    }

Ditto here.

[David Kilzer (:ddkilzer)]

Comment on attachment 404875 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=404875&action=review

>> Source/WebKit/Shared/mac/ObjCObjectGraph.mm:178
>> +    }
> 
> No need for { }.
> Ditto below.

Removing these.

>> Source/WebKit/Shared/mac/ObjCObjectGraph.mm:252
>> +    }
> 
> Ditto here.

Keeping these since there are two lines of code.

Thanks!

[David Kilzer (:ddkilzer)]

Created attachment 404926 [details]
Patch for landing

[EWS]

Committed r264701: <https://trac.webkit.org/changeset/264701>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404926 [details].

[David Kilzer (:ddkilzer)]

(In reply to EWS from comment #5)
> Committed r264701: <https://trac.webkit.org/changeset/264701>
> 
> All reviewed patches have been landed. Closing bug and clearing flags on
> attachment 404926 [details].

Minor follow-up fix:

Committed r264720: <https://trac.webkit.org/changeset/264720>

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #6)
> (In reply to EWS from comment #5)
> > Committed r264701: <https://trac.webkit.org/changeset/264701>
> > 
> > All reviewed patches have been landed. Closing bug and clearing flags on
> > attachment 404926 [details].
> 
> Minor follow-up fix:
> 
> Committed r264720: <https://trac.webkit.org/changeset/264720>

Second minor follow-up improvement:

Committed r264732: <https://trac.webkit.org/changeset/264732>