Bug 214606 - [webkitcorepy] Add an auto-installer
Summary: [webkitcorepy] Add an auto-installer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 13
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-21 11:25 PDT by Jonathan Bedard
Modified: 2020-07-30 20:25 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.15 KB, patch)
2020-07-21 11:45 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (19.56 KB, patch)
2020-07-22 13:55 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (27.91 KB, patch)
2020-07-22 14:09 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (19.99 KB, patch)
2020-07-22 14:24 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (298.40 KB, patch)
2020-07-22 14:51 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (19.99 KB, patch)
2020-07-22 15:00 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (20.01 KB, patch)
2020-07-22 15:06 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (21.85 KB, patch)
2020-07-22 15:18 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (21.80 KB, patch)
2020-07-29 07:16 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-07-21 11:25:48 PDT 
Add an auto-installer that uses pypi to find and download compatible packages.

Unlike the webkitpy auto-installer, the goal of the new auto-installer is that adding a new auto-installed package should be a one-line change.
Comment 1 Jonathan Bedard 2020-07-21 11:45:12 PDT 
Created attachment 404844 [details]
Patch
Comment 2 Jonathan Bedard 2020-07-22 13:55:52 PDT 
Created attachment 404956 [details]
Patch
Comment 3 Jonathan Bedard 2020-07-22 13:58:12 PDT 
(In reply to Jonathan Bedard from comment #2)
> Created attachment 404956 [details]
> Patch

Rather than fight with the ssl configurations of various different platforms and versions, let's just include the root cert needed by PyPi and be done with it. Most https requests will end up being made through requests, so the root certificate is really just for for PyPi.
Comment 4 Jonathan Bedard 2020-07-22 14:09:05 PDT 
Created attachment 404959 [details]
Patch
Comment 5 Jonathan Bedard 2020-07-22 14:24:20 PDT 
Created attachment 404962 [details]
Patch
Comment 6 Jonathan Bedard 2020-07-22 14:51:55 PDT 
Created attachment 404968 [details]
Patch
Comment 7 Jonathan Bedard 2020-07-22 15:00:36 PDT 
Created attachment 404973 [details]
Patch
Comment 8 Jonathan Bedard 2020-07-22 15:06:05 PDT 
Created attachment 404975 [details]
Patch
Comment 9 Jonathan Bedard 2020-07-22 15:18:15 PDT 
Created attachment 404980 [details]
Patch
Comment 10 Jonathan Bedard 2020-07-22 15:21:03 PDT 
Comment on attachment 404980 [details]
Patch

The difficulties I've had with this patch illustrate why a dedicated auto-installer would be best. We can standardize our certificate roots so we aren't relying on system certificates.
Comment 11 Radar WebKit Bug Importer 2020-07-28 11:26:18 PDT 
<rdar://problem/66228103>
Comment 12 Jonathan Bedard 2020-07-29 07:16:03 PDT 
Created attachment 405456 [details]
Patch
Comment 13 Jonathan Bedard 2020-07-29 11:43:46 PDT 
Committed r265049: <https://trac.webkit.org/changeset/265049>
Comment 14 Jonathan Bedard 2020-07-29 14:50:04 PDT 
Committed r265058: <https://trac.webkit.org/changeset/265058>
Comment 15 Jonathan Bedard 2020-07-30 20:25:35 PDT 
Committed r265128: <https://trac.webkit.org/changeset/265128>