Bug 214586 – Fix FinalizationRegistry GC finalizer interation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

Fix FinalizationRegistry GC finalizer interation

[Keith Miller]

Created attachment 404791 [details]
Patch

[Mark Lam]

Comment on attachment 404791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404791&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        Turns out when you remove the ith element from an table and you

/an table/a Vector/.  I think the data structure you're using is a Vector, right?

[Mark Lam]

Can you also check why the jsc EWS bot is failing?  Please fix if it's your failure.  Please file a bug if the failure is not yours.  Thanks.

[Yusuke Suzuki]

Comment on attachment 404791 [details]
Patch

r=me too.

[Keith Miller]

Created attachment 404846 [details]
Patch for landing

[Keith Miller]

Created attachment 404847 [details]
Patch for landing

[Mark Lam]

Comment on attachment 404846 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=404846&action=review

> Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp:113
> +    ASSERT(vm.currentThreadIsHoldingAPILock() || (Thread::mayBeGCThread() && ticket->vm().heap.worldIsStopped()));

Why ticket->vm()?  You have the VM& right there.

[Keith Miller]

Created attachment 404848 [details]
Patch for landing

[Keith Miller]

(In reply to Mark Lam from comment #7)
> Comment on attachment 404846 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404846&action=review
> 
> > Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp:113
> > +    ASSERT(vm.currentThreadIsHoldingAPILock() || (Thread::mayBeGCThread() && ticket->vm().heap.worldIsStopped()));
> 
> Why ticket->vm()?  You have the VM& right there.

Fair enough, twas a copy paste artifact.

[EWS]

Committed r264673: <https://trac.webkit.org/changeset/264673>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404848 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65897598>