<rdar://problem/61278487>
Created attachment 404787 [details] Patch
Created attachment 404788 [details] Patch
Created attachment 404845 [details] Patch
Created attachment 404866 [details] Patch
Comment on attachment 404866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404866&action=review Does this in-memory IDB line up with the IDB third-party ServiceWorkers get? If so, can we add a test to show that? Is this WK2-specific? I believe so since WK1 already has partitioned IDB afaik. If it is WK2-specific, please say so in the change log. Does partitioned IDB get cleared when IDB is cleared for the third-party, the partition (the first party), or both? Can we add a test for that? > Source/WebCore/ChangeLog:10 > + in-memory storage. Please add specifics on what the partitioning key is, i.e. origin (scheme+host+port), host, or registrable domain.
(In reply to John Wilander from comment #5) > Comment on attachment 404866 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404866&action=review > > Does this in-memory IDB line up with the IDB third-party ServiceWorkers get? > If so, can we add a test to show that? > Now IDB should have the same behavior as localStorage, so workers should have temporary storage too. Will try adding a test. > Is this WK2-specific? I believe so since WK1 already has partitioned IDB > afaik. If it is WK2-specific, please say so in the change log. > No, both wk1 and wk2 use the same logic: they didn't allow IDB on 3rd party frames. Check mac-wk1 bot behavior on updated test. > Does partitioned IDB get cleared when IDB is cleared for the third-party, > the partition (the first party), or both? Can we add a test for that? > Both. Will add a test. > > Source/WebCore/ChangeLog:10 > > + in-memory storage. > > Please add specifics on what the partitioning key is, i.e. origin > (scheme+host+port), host, or registrable domain. Sure.
Created attachment 405019 [details] Patch
Comment on attachment 405019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405019&action=review r=me > Source/WebCore/Modules/indexeddb/IDBFactory.cpp:58 > + if (!context.securityOrigin()->canAccessDatabase(nullptr)) > return true; This check looks a little mysterious. It's nice that we're being consistent with LocalStorage here. Probably deserves some follow-up for both LocalStorage and IDB to make this check clearer.
Seems like all review comments so far have been addressed, so I'll say r=me.
Committed r264790: <https://trac.webkit.org/changeset/264790> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405019 [details].