Bug 214571 - [ews] Use -q while unzipping layout-test-results.zip
Summary: [ews] Use -q while unzipping layout-test-results.zip
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-20 13:47 PDT by Aakash Jain
Modified: 2020-07-21 09:38 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.31 KB, patch)
2020-07-20 13:49 PDT, Aakash Jain
jbedard: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-07-20 13:47:02 PDT
Wer should use -q while unzipping layout-test-results.zip in ews. By default unzip command lists all the filnames inside the zip, which can be thousands of files. We don't need to log all these, and store all this data in the buildbot database. This command is also run on the server, and disabling this logging might also have small performance improvement.

For e.g.: In https://ews-build.webkit.org/#/builders/17/builds/4344/steps/12/logs/stdio there were over 50000 lines (taking few megabytes of space in the database).
Comment 1 Aakash Jain 2020-07-20 13:47:36 PDT
Similar to <rdar://problem/34743962>.
Comment 2 Aakash Jain 2020-07-20 13:49:29 PDT
Created attachment 404756 [details]
Patch
Comment 3 EWS 2020-07-20 15:36:06 PDT
Found 1 new test failure: webgl/2.0.0/conformance2/state/gl-object-get-calls.html
Comment 4 Aakash Jain 2020-07-20 15:38:43 PDT
Committed r264626: <https://trac.webkit.org/changeset/264626>
Comment 5 Radar WebKit Bug Importer 2020-07-20 15:39:14 PDT
<rdar://problem/65851854>
Comment 6 Aakash Jain 2020-07-21 07:12:26 PDT
Restated Buildbot to pick up this change.
Comment 7 Aakash Jain 2020-07-21 09:38:05 PDT
Working fine, e.g.: https://ews-build.webkit.org/#/builders/32/builds/14243/steps/14/logs/stdio