WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
214569
[WPE] WebPopupItem should always be forward declared as struct
https://bugs.webkit.org/show_bug.cgi?id=214569
Summary
[WPE] WebPopupItem should always be forward declared as struct
Adrian Perez
Reported
2020-07-20 13:40:16 PDT
../Source/WebKit/UIProcess/API/wpe/WebKitWebViewClient.h:38:1: warning: class 'WebPopupItem' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags] class WebPopupItem; ^ ../Source/WebKit/UIProcess/WebPageProxy.h:357:8: note: previous use is here struct WebPopupItem; ^
Attachments
Patch for landing
(1.22 KB, patch)
2020-07-20 13:44 PDT
,
Adrian Perez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adrian Perez
Comment 1
2020-07-20 13:44:51 PDT
Created
attachment 404754
[details]
Patch for landing
EWS
Comment 2
2020-07-20 15:16:46 PDT
Committed
r264623
: <
https://trac.webkit.org/changeset/264623
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 404754
[details]
.
Radar WebKit Bug Importer
Comment 3
2020-07-20 15:17:13 PDT
<
rdar://problem/65850780
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug