Bug 214569 - [WPE] WebPopupItem should always be forward declared as struct
Summary: [WPE] WebPopupItem should always be forward declared as struct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-20 13:40 PDT by Adrian Perez
Modified: 2020-07-20 15:17 PDT (History)
1 user (show)

See Also:

Attachments
Patch for landing (1.22 KB, patch)
2020-07-20 13:44 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-07-20 13:40:16 PDT 
../Source/WebKit/UIProcess/API/wpe/WebKitWebViewClient.h:38:1: warning: class 'WebPopupItem' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]
class WebPopupItem;
^
../Source/WebKit/UIProcess/WebPageProxy.h:357:8: note: previous use is here
struct WebPopupItem;
       ^
Comment 1 Adrian Perez 2020-07-20 13:44:51 PDT 
Created attachment 404754 [details]
Patch for landing
Comment 2 EWS 2020-07-20 15:16:46 PDT 
Committed r264623: <https://trac.webkit.org/changeset/264623>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404754 [details].
Comment 3 Radar WebKit Bug Importer 2020-07-20 15:17:13 PDT 
<rdar://problem/65850780>