Bug 214555 - pluginElementCustomGetOwnPropertySlot() should support VMInquiry requests.
Summary: pluginElementCustomGetOwnPropertySlot() should support VMInquiry requests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-20 09:42 PDT by Mark Lam
Modified: 2020-07-25 22:12 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (8.59 KB, patch)
2020-07-24 21:25 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (9.93 KB, patch)
2020-07-24 21:37 PDT, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-07-20 09:42:27 PDT 
<rdar://problem/65625807>
Comment 1 Mark Lam 2020-07-20 17:07:36 PDT 
<rdar://problem/65855400>
Comment 2 Mark Lam 2020-07-24 21:25:05 PDT 
Created attachment 405220 [details]
proposed patch.
Comment 3 Mark Lam 2020-07-24 21:37:20 PDT 
Created attachment 405221 [details]
proposed patch.
Comment 4 Yusuke Suzuki 2020-07-25 21:20:10 PDT 
Comment on attachment 405221 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=405221&action=review

r=me

> Source/JavaScriptCore/runtime/JSObjectInlines.h:136
> +        if (slot.isVMInquiry() && slot.isTaintedByOpaqueObject())

Let's put `UNLIKELY`.

> Source/JavaScriptCore/runtime/JSObjectInlines.h:179
> +            if (slot.isVMInquiry() && slot.isTaintedByOpaqueObject())

Let's put UNLIKELY
Comment 5 Mark Lam 2020-07-25 22:12:06 PDT 
Thanks for the review.  I've applied the fixes.

Landed in r264895: <http://trac.webkit.org/r264895>.