Bug 214554 – [GTK] WebKitSettings:enable-private-browsing missing G_PARAM_DEPRECATED

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

WebKitSettings:enable-private-browsing is missing G_PARAM_DEPRECATED

[Michael Catanzaro]

Created attachment 404717 [details]
Patch

[Michael Catanzaro]

Style checker won't like this, since the existing code doesn't follow WebKit code style, but I figure reindenting it to change one line is probably overkill.

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Comment on attachment 404717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404717&action=review

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:957
> +                                                         readWriteConstructParamFlags | G_PARAM_DEPRECATED));

You need a cast here. This doesn't build.

[Michael Catanzaro]

(In reply to Carlos Garcia Campos from comment #4)
> You need a cast here. This doesn't build.

That's what I thought, but I tried without just to see, and it built for me, so I didn't use it. Maybe the cast is no longer required with GCC 10. I tested again just now to be certain, and it really builds fine for me without the cast....

[Michael Catanzaro]

Created attachment 404813 [details]
Patch for landing

[EWS]

Committed r264653: <https://trac.webkit.org/changeset/264653>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404813 [details].