Bug 214554 - [GTK] WebKitSettings:enable-private-browsing missing G_PARAM_DEPRECATED
Summary: [GTK] WebKitSettings:enable-private-browsing missing G_PARAM_DEPRECATED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Depends on:
Reported: 2020-07-20 08:44 PDT by Michael Catanzaro
Modified: 2020-07-21 07:00 PDT (History)
6 users (show)

See Also:

Patch (1.54 KB, patch)
2020-07-20 08:45 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Patch for landing (1.58 KB, patch)
2020-07-21 06:06 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-07-20 08:44:31 PDT
WebKitSettings:enable-private-browsing is missing G_PARAM_DEPRECATED
Comment 1 Michael Catanzaro 2020-07-20 08:45:40 PDT
Created attachment 404717 [details]
Comment 2 Michael Catanzaro 2020-07-20 08:46:12 PDT
Style checker won't like this, since the existing code doesn't follow WebKit code style, but I figure reindenting it to change one line is probably overkill.
Comment 3 EWS Watchlist 2020-07-20 08:46:41 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Carlos Garcia Campos 2020-07-20 23:58:06 PDT
Comment on attachment 404717 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=404717&action=review

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:957
> +                                                         readWriteConstructParamFlags | G_PARAM_DEPRECATED));

You need a cast here. This doesn't build.
Comment 5 Michael Catanzaro 2020-07-21 06:03:52 PDT
(In reply to Carlos Garcia Campos from comment #4)
> You need a cast here. This doesn't build.

That's what I thought, but I tried without just to see, and it built for me, so I didn't use it. Maybe the cast is no longer required with GCC 10. I tested again just now to be certain, and it really builds fine for me without the cast....
Comment 6 Michael Catanzaro 2020-07-21 06:06:57 PDT
Created attachment 404813 [details]
Patch for landing
Comment 7 EWS 2020-07-21 07:00:56 PDT
Committed r264653: <https://trac.webkit.org/changeset/264653>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404813 [details].