Bug 214549 - Some classes have final destructors but are non-final
Summary: Some classes have final destructors but are non-final
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-20 04:31 PDT by Adrian Perez
Modified: 2020-07-20 06:42 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.49 KB, patch)
2020-07-20 04:37 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-07-20 04:31:06 PDT 
../Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h:68:30: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
    ~WebSWServerConnection() final;
                             ^
Comment 1 Adrian Perez 2020-07-20 04:33:09 PDT 
Also WebMessagePortChannelProvider:

../Source/WebKit/WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h:39:38: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
    ~WebMessagePortChannelProvider() final;
                                     ^
Comment 2 Adrian Perez 2020-07-20 04:37:45 PDT 
Created attachment 404710 [details]
Patch
Comment 3 EWS 2020-07-20 06:41:57 PDT 
Committed r264598: <https://trac.webkit.org/changeset/264598>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404710 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-20 06:42:13 PDT 
<rdar://problem/65822676>